From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarkko Sakkinen Subject: Re: [PATCH 2/2] ftpm: firmware TPM running in TEE Date: Wed, 3 Apr 2019 21:19:36 +0300 Message-ID: <20190403181936.GC17006@linux.intel.com> References: <20190402193316.15144-1-sashal@kernel.org> <20190402193316.15144-2-sashal@kernel.org> <20190402135643.02443863@shemminger-XPS-13-9360> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20190402135643.02443863@shemminger-XPS-13-9360> Sender: linux-kernel-owner@vger.kernel.org To: Stephen Hemminger Cc: Sasha Levin , robh+dt@kernel.org, mark.rutland@arm.com, peterhuewe@gmx.de, jgg@ziepe.ca, Microsoft Linux Kernel List , "Bryan Kelly (CSI)" , Thirupathaiah Annapureddy , Sudhakar Evuri , arnd@arndb.de, gregkh@linuxfoundation.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-integrity@vger.kernel.org List-Id: devicetree@vger.kernel.org On Tue, Apr 02, 2019 at 01:56:43PM -0700, Stephen Hemminger wrote: > On Tue, 2 Apr 2019 12:33:16 -0700 > "Sasha Levin" wrote: > > > +/* > > + * ftpm_tee_tpm_op_recv retrieve fTPM response. > > + * @param: chip, the tpm_chip description as specified in > > driver/char/tpm/tpm.h. > > + * @param: buf, the buffer to store data. > > + * @param: count, the number of bytes to read. > > + * @return: In case of success the number of bytes received. > > + * In other case, a < 0 value describing the issue. > > + */ > > You are using a docbook style comment but it doesn't start with > docbook prefix. > > /** > * ftpm_tee_tpm_op_recv retrieve fTPM response. > * > * @param: chip, the tpm_chip description as specified in driver/char/tpm/tpm.h. > * @param: buf, the buffer to store data. > * @param: count, the number of bytes to read. > * @return: In case of success the number of bytes received. > * In other case, a < 0 value describing the issue. > */ This is different commenting style that we use on anything else under drivers/char/tpm. /Jarkko