From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH 3/4] mwifiex: Flag wake-up interrupt as IRQ_NOAUTOEN rather than disabling it too late From: Kalle Valo In-Reply-To: <20190224140426.3267-4-marc.zyngier@arm.com> References: <20190224140426.3267-4-marc.zyngier@arm.com> Message-Id: <20190404102251.6C12561A86@smtp.codeaurora.org> Date: Thu, 4 Apr 2019 10:22:50 +0000 (UTC) To: Marc Zyngier Cc: Amitkumar Karwar , Enric Balletbo i Serra , Ganapathi Bhat , Heiko Stuebner , Nishant Sarmukadam , Rob Herring , Xinming Hu , "David S. Miller" , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org List-ID: Marc Zyngier wrote: > The mwifiex driver makes unsafe assumptions about the state of the > wake-up interrupt. It requests it and only then disable it. Of > course, the interrupt may be screaming for whatever reason at that > time, and the handler will then be called without the interrupt > having been registered with the PM/wakeup subsystem. Oops. > > The right way to handle this kind of situation is to flag the > interrupt with IRQ_NOAUTOEN before requesting it. It will then > stay disabled until someone (the wake-up subsystem) enables it. > > Signed-off-by: Marc Zyngier > Reviewed-by: Brian Norris Failed to apply: fatal: sha1 information is lacking or useless (drivers/net/wireless/marvell/mwifiex/main.c). error: could not build fake ancestor Applying: mwifiex: Flag wake-up interrupt as IRQ_NOAUTOEN rather than disabling it too late Patch failed at 0001 mwifiex: Flag wake-up interrupt as IRQ_NOAUTOEN rather than disabling it too late The copy of the patch that failed is found in: .git/rebase-apply/patch Patch set to Changes Requested. -- https://patchwork.kernel.org/patch/10827971/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches