[PATCH 0/4] Add USB-HOST support to cat874

[PATCH 0/4] Add USB-HOST support to cat874

[Fabrizio Castro]

While trying to add USB-HOST support to the cat874 board,
it came up that of_usb_get_dr_mode_by_phy was selecting
the wrong DT node to use for dr_mode.
Also, drivers/phy/renesas/phy-rcar-gen3-usb2.c was registering
IRQs, no matter the dr_mode.

This series adds all that is required to add USB-HOST support
to the cat874 board, and also removes the hsusb from Draak's DT
as not necessary anymore.

Thanks,
Fab

Fabrizio Castro (4):
  usb: common: Consider only available nodes for dr_mode
  phy: renesas: rcar-gen3-usb2: No need to request IRQ for non-OTG
  arm64: dts: renesas: r8a774c0-cat874: Add USB-HOST support
  arm64: dts: renesas: r8a77995: draak: Remove hsusb node

 arch/arm64/boot/dts/renesas/r8a774c0-cat874.dts | 15 ++++++++++++++
 arch/arm64/boot/dts/renesas/r8a77995-draak.dts  |  5 -----
 drivers/phy/renesas/phy-rcar-gen3-usb2.c        | 26 ++++++++++++-------------
 drivers/usb/common/common.c                     |  2 ++
 4 files changed, 30 insertions(+), 18 deletions(-)

-- 
2.7.4

[PATCH 3/4] arm64: dts: renesas: r8a774c0-cat874: Add USB-HOST support

[Fabrizio Castro]

This patch adds USB 2.0 HOST support to the CAT874 board.

Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
---
 arch/arm64/boot/dts/renesas/r8a774c0-cat874.dts | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a774c0-cat874.dts b/arch/arm64/boot/dts/renesas/r8a774c0-cat874.dts
index f86b3628..7d3b76f 100644
--- a/arch/arm64/boot/dts/renesas/r8a774c0-cat874.dts
+++ b/arch/arm64/boot/dts/renesas/r8a774c0-cat874.dts
@@ -76,10 +76,20 @@
 	};
 };
 
+&ehci0 {
+	dr_mode = "host";
+	status = "okay";
+};
+
 &extal_clk {
 	clock-frequency = <48000000>;
 };
 
+&ohci0 {
+	dr_mode = "host";
+	status = "okay";
+};
+
 &pcie_bus_clk {
 	clock-frequency = <100000000>;
 };
@@ -128,3 +138,8 @@
 	sd-uhs-sdr104;
 	status = "okay";
 };
+
+&usb2_phy0 {
+	renesas,no-otg-pins;
+	status = "okay";
+};
-- 
2.7.4

[PATCH 4/4] arm64: dts: renesas: r8a77995: draak: Remove hsusb node

[Fabrizio Castro]

Patch "usb: common: Consider only available nodes for dr_mode"
fixes the way the DT gets parsed to identify the USB controller
driving the PHY, as such we don't need hsusb to specify dr_mode,
in fact we don't need to enable the hsusb node at all since
the USB interface on the board works as USB host only.

Fixes: 5c6479d9b25b ("arm64: dts: renesas: r8a7799{0|5}: add/enable USB2.0 peripheral")
Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
---
 arch/arm64/boot/dts/renesas/r8a77995-draak.dts | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
index db2bed1..5f13b8b 100644
--- a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
+++ b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
@@ -207,11 +207,6 @@
 	clock-frequency = <48000000>;
 };
 
-&hsusb {
-	dr_mode = "host";
-	status = "okay";
-};
-
 &i2c0 {
 	pinctrl-0 = <&i2c0_pins>;
 	pinctrl-names = "default";
-- 
2.7.4

Re: [PATCH 0/4] Add USB-HOST support to cat874

[Simon Horman]

On Fri, Mar 01, 2019 at 11:05:44AM +0000, Fabrizio Castro wrote:
> While trying to add USB-HOST support to the cat874 board,
> it came up that of_usb_get_dr_mode_by_phy was selecting
> the wrong DT node to use for dr_mode.
> Also, drivers/phy/renesas/phy-rcar-gen3-usb2.c was registering
> IRQs, no matter the dr_mode.
> 
> This series adds all that is required to add USB-HOST support
> to the cat874 board, and also removes the hsusb from Draak's DT
> as not necessary anymore.
> 
> Thanks,
> Fab
> 
> Fabrizio Castro (4):
>   usb: common: Consider only available nodes for dr_mode
>   phy: renesas: rcar-gen3-usb2: No need to request IRQ for non-OTG

Hi Fabrizio,

I am marking the patches below deferred pending acceptance of the patches
above.

>   arm64: dts: renesas: r8a774c0-cat874: Add USB-HOST support
>   arm64: dts: renesas: r8a77995: draak: Remove hsusb node
> 
>  arch/arm64/boot/dts/renesas/r8a774c0-cat874.dts | 15 ++++++++++++++
>  arch/arm64/boot/dts/renesas/r8a77995-draak.dts  |  5 -----
>  drivers/phy/renesas/phy-rcar-gen3-usb2.c        | 26 ++++++++++++-------------
>  drivers/usb/common/common.c                     |  2 ++
>  4 files changed, 30 insertions(+), 18 deletions(-)
> 
> -- 
> 2.7.4
> 

RE: [PATCH 4/4] arm64: dts: renesas: r8a77995: draak: Remove hsusb node

[Fabrizio Castro]

Hello Simon,

I would like to drop this patch.

Thanks,
Fab

> From: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> Sent: 01 March 2019 11:06
> Subject: [PATCH 4/4] arm64: dts: renesas: r8a77995: draak: Remove hsusb node
> 
> Patch "usb: common: Consider only available nodes for dr_mode"
> fixes the way the DT gets parsed to identify the USB controller
> driving the PHY, as such we don't need hsusb to specify dr_mode,
> in fact we don't need to enable the hsusb node at all since
> the USB interface on the board works as USB host only.
> 
> Fixes: 5c6479d9b25b ("arm64: dts: renesas: r8a7799{0|5}: add/enable USB2.0 peripheral")
> Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> ---
>  arch/arm64/boot/dts/renesas/r8a77995-draak.dts | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
> index db2bed1..5f13b8b 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
> @@ -207,11 +207,6 @@
>  	clock-frequency = <48000000>;
>  };
> 
> -&hsusb {
> -	dr_mode = "host";
> -	status = "okay";
> -};
> -
>  &i2c0 {
>  	pinctrl-0 = <&i2c0_pins>;
>  	pinctrl-names = "default";
> --
> 2.7.4

RE: [PATCH 3/4] arm64: dts: renesas: r8a774c0-cat874: Add USB-HOST support

[Fabrizio Castro]

Hello Simon,

Patch "usb: common: Consider only available nodes for dr_mode" has been taken,
and that is enough to get USB 2.0 host to work on the EK874, do you think you
can take this patch now?

Thanks,
Fab

> From: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> Sent: 01 March 2019 11:06
> Subject: [PATCH 3/4] arm64: dts: renesas: r8a774c0-cat874: Add USB-HOST support
> 
> This patch adds USB 2.0 HOST support to the CAT874 board.
> 
> Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> ---
>  arch/arm64/boot/dts/renesas/r8a774c0-cat874.dts | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/renesas/r8a774c0-cat874.dts b/arch/arm64/boot/dts/renesas/r8a774c0-cat874.dts
> index f86b3628..7d3b76f 100644
> --- a/arch/arm64/boot/dts/renesas/r8a774c0-cat874.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a774c0-cat874.dts
> @@ -76,10 +76,20 @@
>  	};
>  };
> 
> +&ehci0 {
> +	dr_mode = "host";
> +	status = "okay";
> +};
> +
>  &extal_clk {
>  	clock-frequency = <48000000>;
>  };
> 
> +&ohci0 {
> +	dr_mode = "host";
> +	status = "okay";
> +};
> +
>  &pcie_bus_clk {
>  	clock-frequency = <100000000>;
>  };
> @@ -128,3 +138,8 @@
>  	sd-uhs-sdr104;
>  	status = "okay";
>  };
> +
> +&usb2_phy0 {
> +	renesas,no-otg-pins;
> +	status = "okay";
> +};
> --
> 2.7.4

Re: [PATCH 4/4] arm64: dts: renesas: r8a77995: draak: Remove hsusb node

[Simon Horman]

On Wed, Apr 03, 2019 at 10:26:18AM +0000, Fabrizio Castro wrote:
> Hello Simon,
> 
> I would like to drop this patch.

Thanks Fabrizio,

I have marked it as "Rejected" in patchwork.

Re: [PATCH 3/4] arm64: dts: renesas: r8a774c0-cat874: Add USB-HOST support

[Simon Horman]

On Wed, Apr 03, 2019 at 10:29:39AM +0000, Fabrizio Castro wrote:
> Hello Simon,
> 
> Patch "usb: common: Consider only available nodes for dr_mode" has been taken,
> and that is enough to get USB 2.0 host to work on the EK874, do you think you
> can take this patch now?

Thanks Fabrizio,

can do. I have applied this for v5.2.