From: "Guido Günther" <agx@sigxcpu.org>
To: Joe Perches <joe@perches.com>
Cc: Thierry Reding <thierry.reding@gmail.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Kevin Hilman <khilman@baylibre.com>,
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
Shawn Guo <shawnguo@kernel.org>,
Jagan Teki <jagan@amarulasolutions.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Johan Hovold <johan@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Sam Ravnborg <sam@ravnborg.org>
Subject: Re: [PATCH] drm/panel: Rocktech jh057n00900: Add terminating newlines to logging
Date: Thu, 4 Apr 2019 17:48:50 +0200 [thread overview]
Message-ID: <20190404154850.GA19334@bogon.m.sigxcpu.org> (raw)
In-Reply-To: <da6f2344396555034cf2476c8338b0ce1c56e0a7.camel@perches.com>
Hi Joe,
On Thu, Apr 04, 2019 at 08:06:09AM -0700, Joe Perches wrote:
> These were missing '\n' terminations, add them.
>
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
> drivers/gpu/drm/panel/panel-rocktech-jh057n00900.c | 19 ++++++++++---------
> 1 file changed, 10 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/gpu/drm/panel/panel-rocktech-jh057n00900.c b/drivers/gpu/drm/panel/panel-rocktech-jh057n00900.c
> index 158a6d548068..d88ea8da2ec2 100644
> --- a/drivers/gpu/drm/panel/panel-rocktech-jh057n00900.c
> +++ b/drivers/gpu/drm/panel/panel-rocktech-jh057n00900.c
> @@ -123,7 +123,7 @@ static int jh057n_init_sequence(struct jh057n *ctx)
>
> ret = mipi_dsi_dcs_exit_sleep_mode(dsi);
> if (ret < 0) {
> - DRM_DEV_ERROR(dev, "Failed to exit sleep mode");
> + DRM_DEV_ERROR(dev, "Failed to exit sleep mode\n");
> return ret;
> }
> /* Panel is operational 120 msec after reset */
> @@ -132,7 +132,7 @@ static int jh057n_init_sequence(struct jh057n *ctx)
> if (ret)
> return ret;
>
> - DRM_DEV_DEBUG_DRIVER(dev, "Panel init sequence done");
> + DRM_DEV_DEBUG_DRIVER(dev, "Panel init sequence done\n");
> return 0;
> }
>
> @@ -172,7 +172,7 @@ static int jh057n_prepare(struct drm_panel *panel)
> if (ctx->prepared)
> return 0;
>
> - DRM_DEV_DEBUG_DRIVER(ctx->dev, "Resetting the panel.");
> + DRM_DEV_DEBUG_DRIVER(ctx->dev, "Resetting the panel\n");
> gpiod_set_value_cansleep(ctx->reset_gpio, 1);
> usleep_range(20, 40);
> gpiod_set_value_cansleep(ctx->reset_gpio, 0);
> @@ -180,7 +180,8 @@ static int jh057n_prepare(struct drm_panel *panel)
>
> ret = jh057n_init_sequence(ctx);
> if (ret < 0) {
> - DRM_DEV_ERROR(ctx->dev, "Panel init sequence failed: %d", ret);
> + DRM_DEV_ERROR(ctx->dev, "Panel init sequence failed: %d\n",
> + ret);
> return ret;
> }
>
> @@ -212,7 +213,7 @@ static int jh057n_get_modes(struct drm_panel *panel)
>
> mode = drm_mode_duplicate(panel->drm, &default_mode);
> if (!mode) {
> - DRM_DEV_ERROR(ctx->dev, "Failed to add mode %ux%u@%u",
> + DRM_DEV_ERROR(ctx->dev, "Failed to add mode %ux%u@%u\n",
> default_mode.hdisplay, default_mode.vdisplay,
> default_mode.vrefresh);
> return -ENOMEM;
> @@ -241,7 +242,7 @@ static int allpixelson_set(void *data, u64 val)
> struct jh057n *ctx = data;
> struct mipi_dsi_device *dsi = to_mipi_dsi_device(ctx->dev);
>
> - DRM_DEV_DEBUG_DRIVER(ctx->dev, "Setting all pixels on");
> + DRM_DEV_DEBUG_DRIVER(ctx->dev, "Setting all pixels on\n");
> dsi_generic_write_seq(dsi, ST7703_CMD_ALL_PIXEL_ON);
> msleep(val * 1000);
> /* Reset the panel to get video back */
> @@ -290,7 +291,7 @@ static int jh057n_probe(struct mipi_dsi_device *dsi)
>
> ctx->reset_gpio = devm_gpiod_get(dev, "reset", GPIOD_OUT_LOW);
> if (IS_ERR(ctx->reset_gpio)) {
> - DRM_DEV_ERROR(dev, "cannot get reset gpio");
> + DRM_DEV_ERROR(dev, "cannot get reset gpio\n");
> return PTR_ERR(ctx->reset_gpio);
> }
>
> @@ -315,12 +316,12 @@ static int jh057n_probe(struct mipi_dsi_device *dsi)
>
> ret = mipi_dsi_attach(dsi);
> if (ret < 0) {
> - DRM_DEV_ERROR(dev, "mipi_dsi_attach failed. Is host ready?");
> + DRM_DEV_ERROR(dev, "mipi_dsi_attach failed. Is host ready?\n");
> drm_panel_remove(&ctx->panel);
> return ret;
> }
>
> - DRM_DEV_INFO(dev, "%ux%u@%u %ubpp dsi %udl - ready",
> + DRM_DEV_INFO(dev, "%ux%u@%u %ubpp dsi %udl - ready\n",
> default_mode.hdisplay, default_mode.vdisplay,
> default_mode.vrefresh,
> mipi_dsi_pixel_format_to_bpp(dsi->format), dsi->lanes);
>
Reviewed-By: Guido Günther <agx@sigxcpu.org>
Thanks,
-- Guido
P.S.: The cc: list is huge, is there a reason for going way past what
get_maintainers puts out for this patch?
next prev parent reply other threads:[~2019-04-04 15:48 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-01 10:35 [PATCH v5 0/3] drm/panel: Support Rocktech jh057n00900 DSI panel Guido Günther
2019-04-01 10:35 ` [PATCH v5 1/3] dt-bindings: Add vendor prefix for ROCKTECH DISPLAYS LIMITED Guido Günther
2019-04-01 10:35 ` [PATCH v5 2/3] dt-bindings: Add Rocktech jh057n00900 panel bindings Guido Günther
2019-04-01 10:35 ` [PATCH v5 3/3] drm/panel: Add Rocktech jh057n00900 panel driver Guido Günther
2019-04-03 16:17 ` [PATCH v5 0/3] drm/panel: Support Rocktech jh057n00900 DSI panel Thierry Reding
2019-04-03 17:11 ` Joe Perches
2019-04-03 20:09 ` Joe Perches
2019-04-03 21:07 ` Sam Ravnborg
2019-04-04 5:02 ` Joe Perches
2019-04-04 10:53 ` Guido Günther
2019-04-04 15:06 ` [PATCH] drm/panel: Rocktech jh057n00900: Add terminating newlines to logging Joe Perches
2019-04-04 15:48 ` Guido Günther [this message]
2019-04-04 16:19 ` Joe Perches
2019-04-04 17:09 ` Thierry Reding
2019-04-04 17:00 ` Sam Ravnborg
2019-04-04 18:55 ` Joe Perches
2019-04-04 19:08 ` Sam Ravnborg
2019-04-04 17:08 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190404154850.GA19334@bogon.m.sigxcpu.org \
--to=agx@sigxcpu.org \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=jagan@amarulasolutions.com \
--cc=joe@perches.com \
--cc=johan@kernel.org \
--cc=khilman@baylibre.com \
--cc=linux-kernel@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=mark.rutland@arm.com \
--cc=martin.blumenstingl@googlemail.com \
--cc=mchehab+samsung@kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
--cc=shawnguo@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).