From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: [PATCH 1/3] dt-bindings: mtd: sunxi: Add new compatible Date: Fri, 5 Apr 2019 11:56:24 +0200 Message-ID: <20190405095624.hv6mfxj7h2dt6mqt@flea> References: <20190404162111.22618-1-miquel.raynal@bootlin.com> <20190404162111.22618-2-miquel.raynal@bootlin.com> <20190405091302.mz3gox5jvoy3ygjr@flea> <20190405112813.07d89534@xps13> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5588042925485601306==" Return-path: In-Reply-To: <20190405112813.07d89534@xps13> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Miquel Raynal Cc: Mark Rutland , devicetree@vger.kernel.org, Vignesh Raghavendra , Tudor Ambarus , Richard Weinberger , Marek Vasut , Chen-Yu Tsai , Rob Herring , linux-mtd@lists.infradead.org, Brian Norris , David Woodhouse , linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org --===============5588042925485601306== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="g5oibzqcggl7e6i7" Content-Disposition: inline --g5oibzqcggl7e6i7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Apr 05, 2019 at 11:28:13AM +0200, Miquel Raynal wrote: > Hi Maxime, > > Maxime Ripard wrote on Fri, 5 Apr 2019 > 11:13:02 +0200: > > > Hi, > > > > On Thu, Apr 04, 2019 at 06:21:09PM +0200, Miquel Raynal wrote: > > > The A33 NAND controller is slightly different than the A10+ ones, > > > eg. DMA handling is a bit different and a few register offsets > > > changed. > > > > > > Introduce a new compatible to represent this version of the IP. > > > > > > Also append '-controller' to the new compatible (which is required for > > > new compatibles) as this is describing a NAND controller and not a > > > NAND chip. > > > > Out of curiosity, why are you requiring that suffix now? > > Because people are confused with the terminology and we see people > mixing all the terms very often: NAND controller, NAND bus, NAND > chip, ECC engine, etc. This node only describes a NAND controller, so > let be more precise and stop naming everything just "NAND". Sounds reasonable :) > > > > > Signed-off-by: Miquel Raynal > > > --- > > > Documentation/devicetree/bindings/mtd/sunxi-nand.txt | 7 ++++++- > > > 1 file changed, 6 insertions(+), 1 deletion(-) > > > > > > diff --git a/Documentation/devicetree/bindings/mtd/sunxi-nand.txt b/Documentation/devicetree/bindings/mtd/sunxi-nand.txt > > > index dcd5a5d80dc0..6128d41d8c59 100644 > > > --- a/Documentation/devicetree/bindings/mtd/sunxi-nand.txt > > > +++ b/Documentation/devicetree/bindings/mtd/sunxi-nand.txt > > > @@ -1,7 +1,12 @@ > > > Allwinner NAND Flash Controller (NFC) > > > > > > Required properties: > > > -- compatible : "allwinner,sun4i-a10-nand". > > > +- compatible : Must be one of: > > > + - "allwinner,sun4i-a10-nand" > > > + - "allwinner,sun8i-a33-nand-controller" > > > + The former may be used by all IPs, however sun8i family > > > + will need the second one in order to make use of the > > > + internal DMA capabilities. > > > > I'm not sure we should have that statement. We have no idea whether or > > not this can be used by all IPs *today*, and we surely don't know > > about the one that are going to come out. > > Shall I just drop the whole comment ("The former" ... "capabilities.")? Yep. Thanks! Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --g5oibzqcggl7e6i7 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXKcmRwAKCRDj7w1vZxhR xW8MAQD4BNi7kYSu+KRgYjwK8X/4FeibzytfB2OaOveyw50krgEA20LHaPoBPDMS VDZMN/6E/C3dpHAh9/06187+1GltOwY= =DvlF -----END PGP SIGNATURE----- --g5oibzqcggl7e6i7-- --===============5588042925485601306== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============5588042925485601306==--