From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Subject: Re: [PATCH v3 00/25] Add generic support for composing LED class device name Date: Sat, 6 Apr 2019 11:46:32 +0200 Message-ID: <20190406094632.GA7546@amd> References: <20190331175501.23471-1-jacek.anaszewski@gmail.com> <20190404132157.GB6124@xo-6d-61-c0.localdomain> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="MGYHOYXEY6WxJCY8" Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Jacek Anaszewski Cc: linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, robh@kernel.org List-Id: devicetree@vger.kernel.org --MGYHOYXEY6WxJCY8 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > >I have not yet gone through the series in great detail. > > > >This will change the userland ABI, right? Now, I understand that old ABI= is bad, but > >will it break someone's code? >=20 > It will not break anyone since the generic support for composing > LED names is used only if struct init_data is provided. Otherwise > led_cdev->name property is taken as is for the LED class device name. >=20 > Moreover, it is safe to switch many of existing DT (or fwnode in > general) based drivers to using generic mechanism. > If the DT provides label property it will be concatenated with the > led_hw_name provided by the driver. The problem would be only with > the drivers whose bindings erroneously require devicename section > in the label. They will need to be left intact. Ok. Plus it seems series causes some compile issues: 924 kbuild tes [j.anaszewski-leds:led_naming_v3 13/37] drivers/leds/leds-pwm.c:117:8: error: 925 N kbuild tes [j.anaszewski-leds:led_naming_v3 17/37] drivers/leds/led-core.o:undefined ref 926 N kbuild tes [j.anaszewski-leds:led_naming_v3 13/37] drivers/leds/leds-pwm.c:117:44: spars 927 N kbuild tes [j.anaszewski-leds:led_naming_v3 13/37] drivers/leds/leds-pwm.c:117:8: error: Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --MGYHOYXEY6WxJCY8 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlyodXgACgkQMOfwapXb+vLduACZAUC3jlCyOGd4yZnVufp2RXu7 FZ0AniSe5nX+hTDEIQHu4oIEZUN6iCSu =26MZ -----END PGP SIGNATURE----- --MGYHOYXEY6WxJCY8--