Re: [PATCH v4 2/4] coresight: replicator: Add new device id for static replicator

Suzuki K Poulose
2019-04-08T10:46:52Z

On 04/06/2019 12:21 PM, Leo Yan wrote:
> This patch adds a device id for the new static replicator compatible
> string; it changes the driver name from "coresight-replicator" to
> "coresight-static-replicator" as well.
>
> Signed-off-by: Leo Yan <leo.yan@linaro.org>
> ---
> drivers/hwtracing/coresight/coresight-replicator.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/hwtracing/coresight/coresight-replicator.c b/drivers/hwtracing/coresight/coresight-replicator.c
> index 4e0da85efd2d..e6a03642bbdb 100644
> --- a/drivers/hwtracing/coresight/coresight-replicator.c
> +++ b/drivers/hwtracing/coresight/coresight-replicator.c
> @@ -285,13 +285,14 @@ static const struct dev_pm_ops replicator_dev_pm_ops = {
>
> static const struct of_device_id static_replicator_match[] = {
> {.compatible = "arm,coresight-replicator"},
> + {.compatible = "arm,coresight-static-replicator"},
> {}

As mentioned in the previous patch, please could you add a warning if
you encounter the old binding, mentioning that it is OBSOLETE.
pr_warn_once() is sufficient.

Otherwise, looks good.

Suzuki