devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Adam Ford <aford173@gmail.com>
Cc: Rob Herring <robh@kernel.org>,
	Christina Quast <cquast@hanoverdisplays.com>,
	Mark Rutland <mark.rutland@arm.com>,
	devicetree <devicetree@vger.kernel.org>,
	Benoit Cousson <bcousson@baylibre.com>,
	Linux-OMAP <linux-omap@vger.kernel.org>,
	Russell King <linux@armlinux.org.uk>
Subject: Re: [PATCH v2 1/6] ARM: dts: am33xx: Added macros for numeric pinmux addresses
Date: Sat, 6 Apr 2019 09:42:14 -0700	[thread overview]
Message-ID: <20190406164214.GH49658@atomide.com> (raw)
In-Reply-To: <CAHCN7xLwva4F6NdH=Ljbz_K3jG11zC=xiyCjp=+XyP3f0-vAwg@mail.gmail.com>

Hi,

* Adam Ford <aford173@gmail.com> [190406 11:30]:
> Is this something you want done for the omap3 as well?  If this get's
> pulled in for am33xx, I can work on doing it for omap3 unless someone
> else already is.

Sure.. There are few things to consider for omap3 though.

The padconf modes are different between various SoC
revisions. I think the base register range should be
the same though. This can be checked in git history
with something like:

$ git show 195c7a52b76d:arch/arm/mach-omap2/mux34xx.c

and

$ git show 195c7a52b76d:arch/arm/mach-omap2/mux34xx.h

So probably as long as we only define the register name,
and not the mode names, we should be good to go.

And making the macro use separate pinconf and mode values
would make things easier eventually to switch to use
#pinctrl-cells = <2> instead of <1> later on.

Regards,

Tony

  reply	other threads:[~2019-04-06 16:42 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-13 14:27 [PATCH 0/2] ARM: dts: am335x: Replace numeric pinmux address with macro defines Christina Quast
2019-03-13 14:27 ` [PATCH 1/2] " Christina Quast
2019-03-14 14:59   ` Tony Lindgren
2019-03-13 14:27 ` [PATCH 2/2] ARM: dts: am335x: Replaced register offsets with defines Christina Quast
2019-03-14 15:05   ` Tony Lindgren
2019-03-14 16:02     ` Christina Quast
2019-03-14 16:12       ` Tony Lindgren
2019-04-02 16:09     ` [PATCH v2 0/6] ARM: dts: am335x: Replace numeric pinmux address with macro defines Christina Quast
2019-04-02 16:09       ` [PATCH v2 1/6] ARM: dts: am33xx: Added macros for numeric pinmux addresses Christina Quast
2019-04-06  6:06         ` Rob Herring
2019-04-06 11:30           ` Adam Ford
2019-04-06 16:42             ` Tony Lindgren [this message]
2019-04-02 16:09       ` [PATCH v2 2/6] ARM: dts: am33xx: Added AM33XX_PADCONF macro Christina Quast
2019-04-06  6:06         ` Rob Herring
2019-04-02 16:09       ` [PATCH v2 3/6] ARM: dts: am335x: bone-common: Replaced register offsets with defines Christina Quast
2019-04-02 16:09       ` [PATCH v2 4/6] ARM: dts: am335x: boneblack-common: " Christina Quast
2019-04-02 16:09       ` [PATCH v2 5/6] ARM: dts: am335x: boneblack-wireless: " Christina Quast
2019-04-02 16:09       ` [PATCH v2 6/6] ARM: dts: am335x: pocketbeagle: " Christina Quast
2019-04-08 17:04       ` [PATCH v2 0/6] ARM: dts: am335x: Replace numeric pinmux address with macro defines Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190406164214.GH49658@atomide.com \
    --to=tony@atomide.com \
    --cc=aford173@gmail.com \
    --cc=bcousson@baylibre.com \
    --cc=cquast@hanoverdisplays.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=mark.rutland@arm.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).