devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Olof Johansson <olof@lixom.net>
To: "Sugaya, Taichi" <sugaya.taichi@socionext.com>
Cc: Maxime Ripard <maxime.ripard@bootlin.com>,
	ARM-SoC Maintainers <arm@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] dt-bindings: cpu: Fix JSON schema
Date: Sun, 7 Apr 2019 15:13:29 -0700	[thread overview]
Message-ID: <20190407221329.skbjjsjvqpnxwime@localhost> (raw)
In-Reply-To: <b3ecf5c5-9b1a-eb8b-95c2-c30a94c8bdd8@socionext.com>

On Tue, Apr 02, 2019 at 08:42:02PM +0900, Sugaya, Taichi wrote:
> Hi,
> 
> On 2019/04/01 22:02, Sugaya, Taichi wrote:
> > Hi,
> > 
> > On 2019/04/01 20:35, Maxime Ripard wrote:
> > > Hi,
> > > 
> > > On Mon, Apr 01, 2019 at 07:52:06PM +0900, Sugaya, Taichi wrote:
> > > > On 2019/04/01 18:10, Maxime Ripard wrote:
> > > > > Hi Sugaya, Arnd, Olof,
> > > > > 
> > > > > On Thu, Mar 28, 2019 at 02:35:54PM -0500, Rob Herring wrote:
> > > > > > +arm-soc
> > > > > > 
> > > > > > On Mon, Mar 18, 2019 at 5:05 AM Maxime Ripard <maxime.ripard@bootlin.com> wrote:
> > > > > > > 
> > > > > > > Commit fd73403a4862 ("dt-bindings: arm: Add SMP enable-method for
> > > > > > > Milbeaut") added support for a new cpu enable-method, but did so using
> > > > > > > tabulations to ident. This is however invalid in the syntax, and resulted
> > > > > > > in a failure when trying to use that schemas for validation.
> > > > > > > 
> > > > > > > Use spaces instead of tabs to indent to fix this.
> > > > > > > 
> > > > > > > Fixes: fd73403a4862 ("dt-bindings: arm: Add SMP enable-method for Milbeaut")
> > > > > > > Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
> > > > > > > ---
> > > > > > >    Documentation/devicetree/bindings/arm/cpus.yaml | 2 +-
> > > > > > >    1 file changed, 1 insertion(+), 1 deletion(-)
> > > > > > 
> > > > > > Reviewed-by: Rob Herring <robh@kernel.org>
> > > > > > 
> > > > > > This should be applied to arm-soc tree having the commit.
> > > > > 
> > > > > Could you pick up that patch?
> > > > 
> > > > I got it.
> > > > My mission is to resubmit your fix-patch added my singned-off tag and
> > > > Rob's reviewed tag...right?
> > > 
> > > If you are part of arm-soc and send your pull requests to Arnd and
> > > Olof, simply pick it up in the same branch than the initial patch was
> > > in. And when you apply that patch, you indeed need to add your
> > > Signed-off-by (note that most commands to commit have an option to do
> > > that automatically: -s and that includes git am) and the Rob's
> > > reviewed-by.
> > > 
> > > Then, send a new pull request to arm-soc.
> > > 
> > 
> > Okay, thanks for your suggestion.
> > I try to make pull request!
> > 
> 
> Sorry I realized that I couldn't make a private repository, so I'll send my Ack instead.
> 
> Acked-by: Sugaya Taichi <sugaya.taichi@socionext.com>

Applied to arm/fixes now. Thanks!


-Olof

  parent reply	other threads:[~2019-04-07 22:13 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-18 10:05 [PATCH] dt-bindings: cpu: Fix JSON schema Maxime Ripard
2019-03-28 19:35 ` Rob Herring
2019-04-01  9:10   ` Maxime Ripard
2019-04-01 10:52     ` Sugaya, Taichi
2019-04-01 11:35       ` Maxime Ripard
2019-04-01 13:02         ` Sugaya, Taichi
2019-04-02 11:42           ` Sugaya, Taichi
2019-04-03  1:29             ` Sugaya, Taichi
2019-04-07 22:13             ` Olof Johansson [this message]
2019-04-08  3:35               ` Sugaya, Taichi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190407221329.skbjjsjvqpnxwime@localhost \
    --to=olof@lixom.net \
    --cc=arm@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=maxime.ripard@bootlin.com \
    --cc=robh+dt@kernel.org \
    --cc=sugaya.taichi@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).