From mboxrd@z Thu Jan  1 00:00:00 1970
From: Shawn Guo <shawnguo@kernel.org>
Subject: Re: [PATCH] ARM: dts: imx6qdl-udoo: Add Pincfgs for OTG
Date: Thu, 11 Apr 2019 14:54:42 +0800
Message-ID: <20190411065440.GB26817@dragon>
References: <1554566420-1008-1-git-send-email-kueffner.markus@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <linux-kernel-owner@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <1554566420-1008-1-git-send-email-kueffner.markus@gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
To: Markus Kueffner <kueffner.markus@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Sascha Hauer <s.hauer@pengutronix.de>, Pengutronix Kernel Team <kernel@pengutronix.de>, Fabio Estevam <festevam@gmail.com>, NXP Linux Team <linux-imx@nxp.com>, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
List-Id: devicetree@vger.kernel.org

On Sat, Apr 06, 2019 at 06:00:20PM +0200, Markus Kueffner wrote:
> Add Pincfgs to enable the i.MX6's OTG feature for UDOO
> 
> Signed-off-by: Markus Kueffner <kueffner.markus@gmail.com>
> ---
>  arch/arm/boot/dts/imx6qdl-udoo.dtsi | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx6qdl-udoo.dtsi b/arch/arm/boot/dts/imx6qdl-udoo.dtsi
> index 776bfc7..42954ee 100644
> --- a/arch/arm/boot/dts/imx6qdl-udoo.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-udoo.dtsi
> @@ -221,6 +221,14 @@
>  			>;
>  		};
>  
> +		pinctrl_usbotg: usbotg {
> +			fsl,pins = <
> +				MX6QDL_PAD_GPIO_1__USB_OTG_ID 0x17059
> +				MX6QDL_PAD_EIM_D22__USB_OTG_PWR 0x17059
> +				MX6QDL_PAD_EIM_D21__USB_OTG_OC 0x17059
> +			>;
> +		};
> +

I know ac97 is out of order, but I still would like to keep pinctrl
nodes sort alphabetically.  That said, pinctrl_usbotg should go after
pinctrl_usbh.

>  		pinctrl_ac97_running: ac97running {
>  			fsl,pins = <
>  				MX6QDL_PAD_DI0_PIN2__AUD6_TXD		0x1b0b0
> @@ -294,6 +302,14 @@
>  	status = "okay";
>  };
>  
> +&usbotg {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_usbotg>;
> +	fsl,power-line-polarity-active-high;
> +	fsl,over-current-polarity-active-low;

Are these two properties supported by upstream bindings and driver?

Shawn

> +	status = "okay";
> +};
> +
>  &audmux {
>  	status = "okay";
>  };
> -- 
> 2.1.4
>