From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolin Chen Subject: Re: [PATCH v4 4/4] ASoC: fsl_audmix: cache pdev->dev pointer Date: Thu, 11 Apr 2019 13:21:18 -0700 Message-ID: <20190411202117.GC13170@Asurada-Nvidia.nvidia.com> References: <1554894380-25153-1-git-send-email-viorel.suman@nxp.com> <1554894380-25153-5-git-send-email-viorel.suman@nxp.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1554894380-25153-5-git-send-email-viorel.suman@nxp.com> Sender: linux-kernel-owner@vger.kernel.org To: Viorel Suman Cc: Timur Tabi , Xiubo Li , Fabio Estevam , Liam Girdwood , Mark Brown , Jaroslav Kysela , Rob Herring , Mark Rutland , Takashi Iwai , Shawn Guo , Sascha Hauer , Julia Lawall , Viorel Suman , Pengutronix Kernel Team , dl-linux-imx , "alsa-devel@alsa-project.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" List-Id: devicetree@vger.kernel.org On Wed, Apr 10, 2019 at 11:06:39AM +0000, Viorel Suman wrote: > There should be no trouble to understand dev = pdev->dev. > This can save some space to have more print info or save > some wrapped lines. Change looks fine. Ack. > Signed-off-by: Viorel Suman > Suggested-by: Nicolin Chen I think usually Suggested-by comes above Signed-off-by. This was originally in your change already, so you can replace: -Suggested-by: Nicolin Chen -Acked-by: Nicolin Chen Just a chance for it to get resent without being a noise :)