From: Mark Rutland <mark.rutland@arm.com>
To: Jeffrey Hugo <jeffrey.l.hugo@gmail.com>
Cc: bjorn.andersson@linaro.org, agross@kernel.org,
david.brown@linaro.org, robh+dt@kernel.org, lee.jones@linaro.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] arm64: dts: qcom: Add Lenovo Miix 630
Date: Fri, 12 Apr 2019 15:47:13 +0100 [thread overview]
Message-ID: <20190412144712.GA7481@lakrids.cambridge.arm.com> (raw)
In-Reply-To: <20190411205144.43557-1-jeffrey.l.hugo@gmail.com>
On Thu, Apr 11, 2019 at 01:51:44PM -0700, Jeffrey Hugo wrote:
> This adds the initial DT for the Lenovo Miix 630 laptop. Supported
> functionality includes USB (host), microSD-card, keyboard, and trackpad.
>
> Signed-off-by: Jeffrey Hugo <jeffrey.l.hugo@gmail.com>
> ---
>
> v2:
> -Changed "cls" to "clam" since feedback indicated "cls" is too opaque, but
> "clamshell" is a mouthfull. "clam" seems to be a happy medium.
Please use "clamshell". The extra 5 characters aren't going to hurt
anyone, and it avoids having yet another short name just confuses
matters further.
[...]
> + keyboard@3a {
> + /* QTEC0001 is the ACPI HID, which could be used for quirks */
> + compatible = "QTEC0001", "hid-over-i2c";
As mentioned last time, please drop the ACPI HID, and allocate a real
compatible string.
Thanks,
Mark.
next prev parent reply other threads:[~2019-04-12 14:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-11 20:51 [PATCH v2] arm64: dts: qcom: Add Lenovo Miix 630 Jeffrey Hugo
2019-04-12 14:47 ` Mark Rutland [this message]
2019-04-12 15:19 ` Jeffrey Hugo
2019-04-12 15:30 ` Mark Rutland
2019-04-12 15:48 ` Jeffrey Hugo
2019-04-12 18:01 ` Bjorn Andersson
2019-04-12 18:41 ` Jeffrey Hugo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190412144712.GA7481@lakrids.cambridge.arm.com \
--to=mark.rutland@arm.com \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jeffrey.l.hugo@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox