From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: [PATCH 1/4] dt-bindings: sound: sun4i-spdif: Add Allwinner H6 compatible Date: Mon, 15 Apr 2019 10:04:43 +0200 Message-ID: <20190415080443.frubh4ln4agrdsfe@flea> References: <20190411214422.2267-1-peron.clem@gmail.com> <20190411214422.2267-2-peron.clem@gmail.com> Reply-To: maxime.ripard-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="asihfkwa6t6ultx7" Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Content-Disposition: inline In-Reply-To: <20190411214422.2267-2-peron.clem-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: =?utf-8?B?Q2zDqW1lbnQgUMOpcm9u?= Cc: Rob Herring , Chen-Yu Tsai , Icenowy Zheng , Jagan Teki , Jernej Skrabec , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org List-Id: devicetree@vger.kernel.org --asihfkwa6t6ultx7 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Thu, Apr 11, 2019 at 11:44:19PM +0200, Cl=C3=A9ment P=C3=A9ron wrote: > Allwinner H6 has a SPDIF controller with an increase of the fifo > size and the possibility to output the master clock. > However it's still compatible with the already existing driver for > Allwiner H3. > > Add this compatible in the device-tree bindings documentation. How was this tested? After looking at the datasheet, it looks like it's still significantly different. In particular: - The MCLK divider isn't at the same offset - The bits to flush the FIFO aren't at the same offset - The FIFO trigger levels aren't at the same offset - The FIFO status register layout is almost entirely different So it doesn't really look compatible to me Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --=20 You received this message because you are subscribed to the Google Groups "= linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an e= mail to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org For more options, visit https://groups.google.com/d/optout. --asihfkwa6t6ultx7 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXLQ7GwAKCRDj7w1vZxhR xeXDAQDHMpbzO3Xd4BiFTccIZGTf5U3cg5fsy8liJ1h36l0dkQD/eWFJGNLTdfgp XIMHvRXdOlHga2dLvRe/m+JoPKzIYw4= =LS+j -----END PGP SIGNATURE----- --asihfkwa6t6ultx7--