From: kbuild test robot <lkp@intel.com>
To: David Bauer <mail@david-bauer.net>
Cc: kbuild-all@01.org, devicetree@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH 3/3] net: mdio: rename mdio_device reset to reset_gpio
Date: Tue, 16 Apr 2019 07:04:22 +0800 [thread overview]
Message-ID: <201904160702.oPgFE9WO%lkp@intel.com> (raw)
In-Reply-To: <20190415123840.31407-3-mail@david-bauer.net>
[-- Attachment #1: Type: text/plain, Size: 3591 bytes --]
Hi David,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on net/master]
[also build test ERROR on v5.1-rc5 next-20190415]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/David-Bauer/dt-bindings-net-add-PHY-reset-controller-binding/20190416-061343
config: i386-randconfig-x010-201915 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
All errors (new ones prefixed by >>):
drivers/net/phy/at803x.c: In function 'at803x_link_change_notify':
>> drivers/net/phy/at803x.c:337:19: error: 'struct mdio_device' has no member named 'reset'
if (phydev->mdio.reset && !priv->phy_reset) {
^
vim +337 drivers/net/phy/at803x.c
77a99394 Zhao Qiang 2014-03-28 324
13a56b44 Daniel Mack 2014-06-18 325 static void at803x_link_change_notify(struct phy_device *phydev)
13a56b44 Daniel Mack 2014-06-18 326 {
13a56b44 Daniel Mack 2014-06-18 327 struct at803x_priv *priv = phydev->priv;
13a56b44 Daniel Mack 2014-06-18 328
13a56b44 Daniel Mack 2014-06-18 329 /*
13a56b44 Daniel Mack 2014-06-18 330 * Conduct a hardware reset for AT8030 every time a link loss is
13a56b44 Daniel Mack 2014-06-18 331 * signalled. This is necessary to circumvent a hardware bug that
13a56b44 Daniel Mack 2014-06-18 332 * occurs when the cable is unplugged while TX packets are pending
13a56b44 Daniel Mack 2014-06-18 333 * in the FIFO. In such cases, the FIFO enters an error mode it
13a56b44 Daniel Mack 2014-06-18 334 * cannot recover from by software.
13a56b44 Daniel Mack 2014-06-18 335 */
13a56b44 Daniel Mack 2014-06-18 336 if (phydev->state == PHY_NOLINK) {
bafbdd52 Sergei Shtylyov 2017-12-04 @337 if (phydev->mdio.reset && !priv->phy_reset) {
13a56b44 Daniel Mack 2014-06-18 338 struct at803x_context context;
13a56b44 Daniel Mack 2014-06-18 339
13a56b44 Daniel Mack 2014-06-18 340 at803x_context_save(phydev, &context);
13a56b44 Daniel Mack 2014-06-18 341
bafbdd52 Sergei Shtylyov 2017-12-04 342 phy_device_reset(phydev, 1);
13a56b44 Daniel Mack 2014-06-18 343 msleep(1);
bafbdd52 Sergei Shtylyov 2017-12-04 344 phy_device_reset(phydev, 0);
d57019d1 Sergei Shtylyov 2016-03-23 345 msleep(1);
13a56b44 Daniel Mack 2014-06-18 346
13a56b44 Daniel Mack 2014-06-18 347 at803x_context_restore(phydev, &context);
13a56b44 Daniel Mack 2014-06-18 348
72ba48be Andrew Lunn 2016-01-06 349 phydev_dbg(phydev, "%s(): phy was reset\n",
13a56b44 Daniel Mack 2014-06-18 350 __func__);
13a56b44 Daniel Mack 2014-06-18 351 priv->phy_reset = true;
13a56b44 Daniel Mack 2014-06-18 352 }
13a56b44 Daniel Mack 2014-06-18 353 } else {
13a56b44 Daniel Mack 2014-06-18 354 priv->phy_reset = false;
13a56b44 Daniel Mack 2014-06-18 355 }
13a56b44 Daniel Mack 2014-06-18 356 }
13a56b44 Daniel Mack 2014-06-18 357
:::::: The code at line 337 was first introduced by commit
:::::: bafbdd527d569c8200521f2f7579f65a044271be phylib: Add device reset GPIO support
:::::: TO: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
:::::: CC: David S. Miller <davem@davemloft.net>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 27237 bytes --]
next prev parent reply other threads:[~2019-04-15 23:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-15 12:38 [PATCH 1/3] dt-bindings: net: add PHY reset controller binding David Bauer
2019-04-15 12:38 ` [PATCH 2/3] net: phy: add support for reset-controller David Bauer
2019-04-15 17:01 ` Andrew Lunn
2019-04-15 12:38 ` [PATCH 3/3] net: mdio: rename mdio_device reset to reset_gpio David Bauer
2019-04-15 17:02 ` Andrew Lunn
2019-04-15 23:04 ` kbuild test robot [this message]
2019-04-16 2:21 ` kbuild test robot
2019-04-16 2:29 ` kbuild test robot
2019-04-15 17:04 ` [PATCH 1/3] dt-bindings: net: add PHY reset controller binding Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201904160702.oPgFE9WO%lkp@intel.com \
--to=lkp@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=kbuild-all@01.org \
--cc=mail@david-bauer.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).