From: Maxime Ripard <maxime.ripard@bootlin.com>
To: "Petr Štetiar" <ynezz@true.cz>
Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>, Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Frank Rowand <frowand.list@gmail.com>,
John Crispin <john@phrozen.org>, Felix Fietkau <nbd@nbd.name>
Subject: Re: [PATCH] of_net: add mtd-mac-address support to of_get_mac_address()
Date: Wed, 17 Apr 2019 12:15:57 +0200 [thread overview]
Message-ID: <20190417101557.6jicrn56dqaccxar@flea> (raw)
In-Reply-To: <20190417094921.GB79403@meh.true.cz>
[-- Attachment #1: Type: text/plain, Size: 1834 bytes --]
On Wed, Apr 17, 2019 at 11:49:21AM +0200, Petr Štetiar wrote:
> Maxime Ripard <maxime.ripard@bootlin.com> [2019-04-17 10:06:14]:
>
> Hi Maxime,
>
> > On Tue, Apr 16, 2019 at 10:05:00PM +0200, Petr Štetiar wrote:
> > > From: John Crispin <john@phrozen.org>
> > >
> > > Many embedded devices have information such as MAC addresses stored
> > > inside MTD devices. This patch allows us to add a property inside a node
> > > describing a network interface. The new property points at a MTD
> > > partition with an offset where the MAC address can be found.
> > >
> > > This patch has originated in OpenWrt some time ago, so in order to
> > > consider usefulness of this patch, here are some real-world numbers
> > > which hopefully speak for themselves:
> > >
> > > * mtd-mac-address used 497 times in 357 device tree files
> > > * mtd-mac-address-increment used 74 times in 58 device tree files
> > > * mtd-mac-address-increment-byte used 1 time in 1 device tree file
> >
> > NVMEM is supported by of_net already and there's an MTD-to-nvmem
> > bridge already, so it doesn't look really necessary to create
> > additional properties that cover the same use case.
>
> if those use cases could be handled with NVMEM, then I'm all in. As I can't
> find any example in some device tree file in the kernel tree yet and the
> documentation isn't clear to me about this topic either, could you please help
> me and provide me with some NVMEM based example for the following simplified
> use case? Or what do I need to bend/patch in order to support this within
> NVME.
https://github.com/torvalds/linux/blob/master/Documentation/devicetree/bindings/nvmem/nvmem.txt
and
https://elixir.bootlin.com/linux/latest/source/net/ethernet/eth.c#L564
Should get you started
Maxime
next prev parent reply other threads:[~2019-04-17 10:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-16 20:05 [PATCH] of_net: add mtd-mac-address support to of_get_mac_address() Petr Štetiar
2019-04-17 0:29 ` Florian Fainelli
2019-04-17 3:01 ` Frank Rowand
2019-04-30 0:48 ` Rob Herring
2019-04-30 1:15 ` Frank Rowand
2019-04-17 5:00 ` Heiner Kallweit
2019-04-17 8:06 ` Maxime Ripard
2019-04-17 9:49 ` Petr Štetiar
2019-04-17 10:15 ` Maxime Ripard [this message]
2019-04-17 12:10 ` Petr Štetiar
2019-04-17 16:06 ` Petr Štetiar
2019-04-17 18:05 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190417101557.6jicrn56dqaccxar@flea \
--to=maxime.ripard@bootlin.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=frowand.list@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=john@phrozen.org \
--cc=mark.rutland@arm.com \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=ynezz@true.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox