From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: Re: [PATCH v3 1/7] ARM: dts: sun8i: r40: bananapi-m2-ultra: Tie GMAC regulators to the PIO Date: Thu, 18 Apr 2019 14:45:12 +0200 Message-ID: <20190418124512.theixlxnsghidpjp@flea> References: <1555492863-88860-1-git-send-email-pgreco@centosproject.org> <1555492863-88860-2-git-send-email-pgreco@centosproject.org> <20190417101757.traviffiulwnzr6x@flea> <666caeac-4297-17b0-065e-00b7fd9623b4@centosproject.org> Reply-To: maxime.ripard-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="zqgbvc2dvbkaqti4" Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Content-Disposition: inline In-Reply-To: <666caeac-4297-17b0-065e-00b7fd9623b4-/kQrlZ55X3WoClj4AeEUq9i2O/JbrIOy@public.gmane.org> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Pablo =?utf-8?Q?Sebasti=C3=A1n?= Greco Cc: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, Rob Herring , Mark Rutland , Chen-Yu Tsai , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org --zqgbvc2dvbkaqti4 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Thu, Apr 18, 2019 at 09:25:19AM -0300, Pablo Sebasti=C3=A1n Greco wrote: > El 17/4/19 a las 07:17, Maxime Ripard escribi=C3=B3: > > On Wed, Apr 17, 2019 at 06:20:56AM -0300, Pablo Greco wrote: > > > When the GMAC support was added to the bananapi-m2-ultra, regulators > > > weren't tied to the pinctrl. Fix that. > > > > > > Signed-off-by: Pablo Greco > > > --- > > > arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git a/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts b/arch= /arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts > > > index c488aaa..3da3598 100644 > > > --- a/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts > > > +++ b/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts > > > @@ -201,6 +201,8 @@ > > > &pio { > > > pinctrl-names =3D "default"; > > > pinctrl-0 =3D <&clk_out_a_pin>; > > > + vcc-pa-supply =3D <®_aldo2>; > > You should list all the regulators that are needed for all the pin > > banks to operate properly, not just PA > Ok, I "think" I finally understand what you mean, so according to schemat= ics > in https://drive.google.com/file/d/0B4PAo2nW2KfndFpmZG1OOWJ5NEU/view, it > should look like this > diff --git a/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts > b/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts > index c488aaa..699579d 100644 > --- a/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts > +++ b/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts > @@ -201,6 +201,12 @@ > =C2=A0&pio { > =C2=A0=C2=A0=C2=A0=C2=A0 pinctrl-names =3D "default"; > =C2=A0=C2=A0=C2=A0=C2=A0 pinctrl-0 =3D <&clk_out_a_pin>; > +=C2=A0=C2=A0=C2=A0 vcc-pa-supply =3D <®_aldo2>; > +=C2=A0=C2=A0=C2=A0 vcc-pc-supply =3D <®_dcdc1>; > +=C2=A0=C2=A0=C2=A0 vcc-pd-supply =3D <®_dcdc1>; > +=C2=A0=C2=A0=C2=A0 vcc-pe-supply =3D <®_eldo1>; > +=C2=A0=C2=A0=C2=A0 vcc-pf-supply =3D <®_dcdc1>; > +=C2=A0=C2=A0=C2=A0 vcc-pg-supply =3D <®_dldo1>; > =C2=A0}; That makes sense yep > =C2=A0®_aldo2 { > -- > > I couldn't find vcc-pb, vcc-ph or vcc-pi. The R40 doesn't have them, so there's no suprise there :) (if you ever want to find that info again in the future, the various vcc-p* that you need to find are in the datasheet) > If this is ok, I'll generate a v4 based on v2, and throw v3 in the trash > where it belongs Sounds good, thanks! Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --=20 You received this message because you are subscribed to the Google Groups "= linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an e= mail to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org For more options, visit https://groups.google.com/d/optout. --zqgbvc2dvbkaqti4 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXLhxWAAKCRDj7w1vZxhR xYjxAP96S50pe+i0RxcXurVb6Gq6P3wILPZgfw2YZfFlBOqBVQD/Y3JUzQSgyTUg sFcR27YRufsmqYO5Euh1nl5UpP4MDAE= =6Yuo -----END PGP SIGNATURE----- --zqgbvc2dvbkaqti4--