[PATCH] ARM: dts: bugfix tqma7 soft reset issue

[PATCH] ARM: dts: bugfix tqma7 soft reset issue

[Bruno Thomsen]

Running reboot command on the TQMa7 board would just hang infinite
at the end of the system shutdown process.

Handling of i.MX7 errata e10574:
Watchdog: A watchdog timeout or software trigger will not reset the SOC.

Signed-off-by: Bruno Thomsen <bruno.thomsen@gmail.com>
Reviewed-by: Markus Niebel <Markus.Niebel@tq-group.com>
---
 arch/arm/boot/dts/imx7-tqma7.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/arch/arm/boot/dts/imx7-tqma7.dtsi b/arch/arm/boot/dts/imx7-tqma7.dtsi
index 85fe461e5e67..896eff839d5e 100644
--- a/arch/arm/boot/dts/imx7-tqma7.dtsi
+++ b/arch/arm/boot/dts/imx7-tqma7.dtsi
@@ -228,5 +228,12 @@
 };
 
 &wdog1 {
+	/*
+	 * Errata e10574:
+	 * WDOG reset needs to run with WDOG_RESET_B signal enabled.
+	 * X1-51 (WDOG1#) signal needs carrier board handling to reset
+	 * TQMa7 on X1-22 (RESET_IN#).
+	 */
+	fsl,ext-reset-output;
 	status = "okay";
 };
-- 
2.20.1

Re: [PATCH] ARM: dts: bugfix tqma7 soft reset issue

[Fabio Estevam]

Hi Bruno,

On Sun, Apr 14, 2019 at 9:06 AM Bruno Thomsen <bruno.thomsen@gmail.com> wrote:

>  &wdog1 {
> +       /*
> +        * Errata e10574:
> +        * WDOG reset needs to run with WDOG_RESET_B signal enabled.
> +        * X1-51 (WDOG1#) signal needs carrier board handling to reset
> +        * TQMa7 on X1-22 (RESET_IN#).
> +        */
> +       fsl,ext-reset-output;
>         status = "okay";

You should also add a pinctrl entry for the watchdog pin.

Please check arch/arm/boot/dts/imx7s-warp.dts for an example.

Re: [PATCH] ARM: dts: bugfix tqma7 soft reset issue

[Bruno Thomsen]

Hi Fabio,

Den søn. 14. apr. 2019 kl. 17.32 skrev Fabio Estevam <festevam@gmail.com>:

> >  &wdog1 {
> > +       /*
> > +        * Errata e10574:
> > +        * WDOG reset needs to run with WDOG_RESET_B signal enabled.
> > +        * X1-51 (WDOG1#) signal needs carrier board handling to reset
> > +        * TQMa7 on X1-22 (RESET_IN#).
> > +        */
> > +       fsl,ext-reset-output;
> >         status = "okay";
>
> You should also add a pinctrl entry for the watchdog pin.

There is a pinctrl entry for the watchdog pin in imx7-mba7.dtsi file
almost identically to imx7s-warp.dts. There are technical 2 pins you can
use for the output, and this dtsi will be used for other product device
trees as well. Where the imx7-mba7.dtsi will only be used for the
development board.
I agree with you that the readability of this dtsi will improve,
and the next device tree I want to mainline also use this pin configuration.

 Bruno

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH v2] ARM: dts: bugfix tqma7 soft reset issue

[Bruno Thomsen]

Running reboot command on the TQMa7 board would just hang infinite
at the end of the system shutdown process.

Handling of i.MX7 errata e10574:
Watchdog: A watchdog timeout or software trigger will not reset the SOC.

Moved pinctrl from common mba7 to common tqma7 dtsi as it improves
readability of errata handling. Most integrators of this SoM will
likely use the development board as inspiration for handling this
SoC issue.

Signed-off-by: Bruno Thomsen <bruno.thomsen@gmail.com>
---
v2:
Moved pinctrl from common development board to common SoM.
Removed Markus reviewed-by as he only acked the fsl,ext-reset-output part.

 arch/arm/boot/dts/imx7-mba7.dtsi  | 11 -----------
 arch/arm/boot/dts/imx7-tqma7.dtsi | 17 +++++++++++++++++
 2 files changed, 17 insertions(+), 11 deletions(-)

diff --git a/arch/arm/boot/dts/imx7-mba7.dtsi b/arch/arm/boot/dts/imx7-mba7.dtsi
index 578341b6848b..50abf18ad30b 100644
--- a/arch/arm/boot/dts/imx7-mba7.dtsi
+++ b/arch/arm/boot/dts/imx7-mba7.dtsi
@@ -472,12 +472,6 @@
 			MX7D_PAD_LPSR_GPIO1_IO05__GPIO1_IO5	0x59
 		>;
 	};
-
-	pinctrl_wdog1: wdog1grp {
-		fsl,pins = <
-			MX7D_PAD_LPSR_GPIO1_IO00__WDOG1_WDOG_B	0x30
-		>;
-	};
 };
 
 &pwm1 {
@@ -554,8 +548,3 @@
 	no-1-8-v;
 	status = "okay";
 };
-
-&wdog1 {
-	pinctrl-names = "default";
-	pinctrl-0 = <&pinctrl_wdog1>;
-};
diff --git a/arch/arm/boot/dts/imx7-tqma7.dtsi b/arch/arm/boot/dts/imx7-tqma7.dtsi
index 85fe461e5e67..9aaed85138cb 100644
--- a/arch/arm/boot/dts/imx7-tqma7.dtsi
+++ b/arch/arm/boot/dts/imx7-tqma7.dtsi
@@ -209,6 +209,14 @@
 	};
 };
 
+&iomuxc_lpsr {
+	pinctrl_wdog1: wdog1grp {
+		fsl,pins = <
+			MX7D_PAD_LPSR_GPIO1_IO00__WDOG1_WDOG_B	0x30
+		>;
+	};
+};
+
 &sdma {
 	status = "okay";
 };
@@ -228,5 +236,14 @@
 };
 
 &wdog1 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_wdog1>;
+	/*
+	 * Errata e10574:
+	 * WDOG reset needs to run with WDOG_RESET_B signal enabled.
+	 * X1-51 (WDOG1#) signal needs carrier board handling to reset
+	 * TQMa7 on X1-22 (RESET_IN#).
+	 */
+	fsl,ext-reset-output;
 	status = "okay";
 };
-- 
2.20.1

Re: [PATCH v2] ARM: dts: bugfix tqma7 soft reset issue

[Shawn Guo]

On Tue, Apr 16, 2019 at 11:08:05AM +0200, Bruno Thomsen wrote:
> Running reboot command on the TQMa7 board would just hang infinite
> at the end of the system shutdown process.
> 
> Handling of i.MX7 errata e10574:
> Watchdog: A watchdog timeout or software trigger will not reset the SOC.
> 
> Moved pinctrl from common mba7 to common tqma7 dtsi as it improves
> readability of errata handling. Most integrators of this SoM will
> likely use the development board as inspiration for handling this
> SoC issue.
> 
> Signed-off-by: Bruno Thomsen <bruno.thomsen@gmail.com>

Applied, thanks.