* [v3] arm64: dts: ls1028a: Add properties for Mali DP500 node
@ 2019-04-16 2:17 Wen He
2019-04-22 1:49 ` Shawn Guo
0 siblings, 1 reply; 3+ messages in thread
From: Wen He @ 2019-04-16 2:17 UTC (permalink / raw)
To: devicetree@vger.kernel.org, shawnguo@kernel.org
Cc: Leo Li, liviu.dudau@arm.com, Wen He
The LS1028A has a LCD controller and Displayport interface that
connects to eDP and Displayport connectors on the LS1028A board.
This patch enables the LCD controller driver on the LS1028A.
Signed-off-by: Alison Wang <alison.wang@nxp.com>
Signed-off-by: Wen He <wen.he_1@nxp.com>
Reviewed-by: Liviu Dudau <liviu.dudau@arm.com>
---
change in v3:
- using 'display0' instead of node name 'display-0' to
fixed syntax error.
change in v2:
- renamed node name 'dp0' to be generic name 'display-0'.
- replace clk name 'xxclk' to 'clock-xx'.
- add newline between properties and child node.
.../arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 38 +++++++++++++++++++
1 file changed, 38 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
index 8dd3501b1333..3c724eb8cb20 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
@@ -70,6 +70,27 @@
clock-output-names = "sysclk";
};
+ dpclk: clock-dp {
+ compatible = "fixed-clock";
+ #clock-cells = <0>;
+ clock-frequency = <27000000>;
+ clock-output-names= "dpclk";
+ };
+
+ aclk: clock-axi {
+ compatible = "fixed-clock";
+ #clock-cells = <0>;
+ clock-frequency = <650000000>;
+ clock-output-names= "aclk";
+ };
+
+ pclk: clock-apb {
+ compatible = "fixed-clock";
+ #clock-cells = <0>;
+ clock-frequency = <650000000>;
+ clock-output-names= "pclk";
+ };
+
reboot {
compatible ="syscon-reboot";
regmap = <&dcfg>;
@@ -433,4 +454,21 @@
};
};
};
+
+ display0: malidp@f080000 {
+ compatible = "arm,mali-dp500";
+ reg = <0x0 0xf080000 0x0 0x10000>;
+ interrupts = <0 222 IRQ_TYPE_LEVEL_HIGH>,
+ <0 223 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-names = "DE", "SE";
+ clocks = <&dpclk>, <&aclk>, <&aclk>, <&pclk>;
+ clock-names = "pxlclk", "mclk", "aclk", "pclk";
+ arm,malidp-output-port-lines = /bits/ 8 <8 8 8>;
+
+ port {
+ dp0_out: endpoint {
+
+ };
+ };
+ };
};
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [v3] arm64: dts: ls1028a: Add properties for Mali DP500 node
2019-04-16 2:17 [v3] arm64: dts: ls1028a: Add properties for Mali DP500 node Wen He
@ 2019-04-22 1:49 ` Shawn Guo
2019-04-22 3:49 ` [EXT] " Wen He
0 siblings, 1 reply; 3+ messages in thread
From: Shawn Guo @ 2019-04-22 1:49 UTC (permalink / raw)
To: Wen He; +Cc: devicetree@vger.kernel.org, Leo Li, liviu.dudau@arm.com
On Tue, Apr 16, 2019 at 02:17:31AM +0000, Wen He wrote:
> The LS1028A has a LCD controller and Displayport interface that
> connects to eDP and Displayport connectors on the LS1028A board.
>
> This patch enables the LCD controller driver on the LS1028A.
>
> Signed-off-by: Alison Wang <alison.wang@nxp.com>
> Signed-off-by: Wen He <wen.he_1@nxp.com>
> Reviewed-by: Liviu Dudau <liviu.dudau@arm.com>
> ---
> change in v3:
> - using 'display0' instead of node name 'display-0' to
> fixed syntax error.
>
> change in v2:
> - renamed node name 'dp0' to be generic name 'display-0'.
> - replace clk name 'xxclk' to 'clock-xx'.
> - add newline between properties and child node.
>
> .../arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 38 +++++++++++++++++++
> 1 file changed, 38 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> index 8dd3501b1333..3c724eb8cb20 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> @@ -70,6 +70,27 @@
> clock-output-names = "sysclk";
> };
>
> + dpclk: clock-dp {
> + compatible = "fixed-clock";
> + #clock-cells = <0>;
> + clock-frequency = <27000000>;
> + clock-output-names= "dpclk";
> + };
> +
> + aclk: clock-axi {
> + compatible = "fixed-clock";
> + #clock-cells = <0>;
> + clock-frequency = <650000000>;
> + clock-output-names= "aclk";
> + };
> +
> + pclk: clock-apb {
> + compatible = "fixed-clock";
> + #clock-cells = <0>;
> + clock-frequency = <650000000>;
> + clock-output-names= "pclk";
> + };
> +
> reboot {
> compatible ="syscon-reboot";
> regmap = <&dcfg>;
> @@ -433,4 +454,21 @@
> };
> };
> };
> +
> + display0: malidp@f080000 {
Hmm, I was saying that node name should be generic, not label name.
That said, the following is actually what I would like to see:
malidp0: display@f080000 {
Shawn
> + compatible = "arm,mali-dp500";
> + reg = <0x0 0xf080000 0x0 0x10000>;
> + interrupts = <0 222 IRQ_TYPE_LEVEL_HIGH>,
> + <0 223 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-names = "DE", "SE";
> + clocks = <&dpclk>, <&aclk>, <&aclk>, <&pclk>;
> + clock-names = "pxlclk", "mclk", "aclk", "pclk";
> + arm,malidp-output-port-lines = /bits/ 8 <8 8 8>;
> +
> + port {
> + dp0_out: endpoint {
> +
> + };
> + };
> + };
> };
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [EXT] Re: [v3] arm64: dts: ls1028a: Add properties for Mali DP500 node
2019-04-22 1:49 ` Shawn Guo
@ 2019-04-22 3:49 ` Wen He
0 siblings, 0 replies; 3+ messages in thread
From: Wen He @ 2019-04-22 3:49 UTC (permalink / raw)
To: Shawn Guo; +Cc: devicetree@vger.kernel.org, Leo Li, liviu.dudau@arm.com
> -----Original Message-----
> From: Shawn Guo [mailto:shawnguo@kernel.org]
> Sent: 2019年4月22日 9:49
> To: Wen He <wen.he_1@nxp.com>
> Cc: devicetree@vger.kernel.org; Leo Li <leoyang.li@nxp.com>;
> liviu.dudau@arm.com
> Subject: [EXT] Re: [v3] arm64: dts: ls1028a: Add properties for Mali DP500
> node
>
> WARNING: This email was created outside of NXP. DO NOT CLICK links or
> attachments unless you recognize the sender and know the content is safe.
>
>
>
> On Tue, Apr 16, 2019 at 02:17:31AM +0000, Wen He wrote:
> > The LS1028A has a LCD controller and Displayport interface that
> > connects to eDP and Displayport connectors on the LS1028A board.
> >
> > This patch enables the LCD controller driver on the LS1028A.
> >
> > Signed-off-by: Alison Wang <alison.wang@nxp.com>
> > Signed-off-by: Wen He <wen.he_1@nxp.com>
> > Reviewed-by: Liviu Dudau <liviu.dudau@arm.com>
> > ---
> > change in v3:
> > - using 'display0' instead of node name 'display-0' to
> > fixed syntax error.
> >
> > change in v2:
> > - renamed node name 'dp0' to be generic name 'display-0'.
> > - replace clk name 'xxclk' to 'clock-xx'.
> > - add newline between properties and child node.
> >
> > .../arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 38
> > +++++++++++++++++++
> > 1 file changed, 38 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > index 8dd3501b1333..3c724eb8cb20 100644
> > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > @@ -70,6 +70,27 @@
> > clock-output-names = "sysclk";
> > };
> >
> > + dpclk: clock-dp {
> > + compatible = "fixed-clock";
> > + #clock-cells = <0>;
> > + clock-frequency = <27000000>;
> > + clock-output-names= "dpclk";
> > + };
> > +
> > + aclk: clock-axi {
> > + compatible = "fixed-clock";
> > + #clock-cells = <0>;
> > + clock-frequency = <650000000>;
> > + clock-output-names= "aclk";
> > + };
> > +
> > + pclk: clock-apb {
> > + compatible = "fixed-clock";
> > + #clock-cells = <0>;
> > + clock-frequency = <650000000>;
> > + clock-output-names= "pclk";
> > + };
> > +
> > reboot {
> > compatible ="syscon-reboot";
> > regmap = <&dcfg>;
> > @@ -433,4 +454,21 @@
> > };
> > };
> > };
> > +
> > + display0: malidp@f080000 {
>
> Hmm, I was saying that node name should be generic, not label name.
> That said, the following is actually what I would like to see:
>
> malidp0: display@f080000 {
>
> Shawn
>
Ha, I got it.
have any other comment? Will send next version patch.
Best Regards,
Wen
> > + compatible = "arm,mali-dp500";
> > + reg = <0x0 0xf080000 0x0 0x10000>;
> > + interrupts = <0 222 IRQ_TYPE_LEVEL_HIGH>,
> > + <0 223 IRQ_TYPE_LEVEL_HIGH>;
> > + interrupt-names = "DE", "SE";
> > + clocks = <&dpclk>, <&aclk>, <&aclk>, <&pclk>;
> > + clock-names = "pxlclk", "mclk", "aclk", "pclk";
> > + arm,malidp-output-port-lines = /bits/ 8 <8 8 8>;
> > +
> > + port {
> > + dp0_out: endpoint {
> > +
> > + };
> > + };
> > + };
> > };
> > --
> > 2.17.1
> >
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-04-22 3:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-04-16 2:17 [v3] arm64: dts: ls1028a: Add properties for Mali DP500 node Wen He
2019-04-22 1:49 ` Shawn Guo
2019-04-22 3:49 ` [EXT] " Wen He
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).