Re: [PATCH v4 2/3] dt-bindings: panel: Add YAML schemas for the Ronbo RB070D30 panel

Re: [PATCH v4 2/3] dt-bindings: panel: Add YAML schemas for the Ronbo RB070D30 panel

[Thierry Reding]

[-- Attachment #1.1: Type: text/plain, Size: 2893 bytes --]

On Wed, Feb 20, 2019 at 09:21:55AM +0100, Maxime Ripard wrote:
> The Ronbo RB070D30 panel is a 1024x600 MIPI-DSI panel.
> 
> Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
> ---
>  Documentation/devicetree/bindings/display/panel/ronbo,rb070d30.yaml | 52 ++++++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 52 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/display/panel/ronbo,rb070d30.yaml

I was doing some patchwork maintenance and noticed that this patch and
patch 1 of this series were not marked as accepted while patch 3 was. I
looked at the tree and then noticed that all three had been applied. So
while I appreciate you marking this as accepted when you've applied it,
please make sure to mark all patches that you've applied as such.

I've now marked these as accepted for consistency, but in the future,
please make always solicit review from device tree maintainers before
applying device tree binding patches.

I would've especially liked a pair of eyes on this as they use the YAML
schema that are still fairly new.

Thierry

> 
> diff --git a/Documentation/devicetree/bindings/display/panel/ronbo,rb070d30.yaml b/Documentation/devicetree/bindings/display/panel/ronbo,rb070d30.yaml
> new file mode 100644
> index 000000000000..a0e6fa1559cf
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/ronbo,rb070d30.yaml
> @@ -0,0 +1,52 @@
> +# SPDX-License-Identifier: (GPL-2.0+ OR X11)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/panel/ronbo,rb070d30.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Ronbo RB070D30 DSI Display Panel
> +
> +maintainers:
> +  - Maxime Ripard <maxime.ripard@bootlin.com>
> +
> +properties:
> +  compatible:
> +    const: ronbo,rb070d30
> +
> +  reg:
> +    description: MIPI-DSI virtual channel
> +
> +  power-gpios:
> +    description: GPIO used for the power pin
> +    maxItems: 1
> +
> +  reset-gpios:
> +    description: GPIO used for the reset pin
> +    maxItems: 1
> +
> +  shlr-gpios:
> +    description: GPIO used for the shlr pin (horizontal flip)
> +    maxItems: 1
> +
> +  updn-gpios:
> +    description: GPIO used for the updn pin (vertical flip)
> +    maxItems: 1
> +
> +  vcc-lcd-supply:
> +    description: Power regulator
> +
> +  backlight:
> +    description: Backlight used by the panel
> +    $ref: "/schemas/types.yaml#/definitions/phandle"
> +
> +required:
> +  - compatible
> +  - power-gpios
> +  - reg
> +  - reset-gpios
> +  - shlr-gpios
> +  - updn-gpios
> +  - vcc-lcd-supply
> +
> +additionalProperties: false
> +  
> -- 
> git-series 0.9.1
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel