* [PATCH] arm64: dts: qcom: qcs404-evb: fix l3 min voltage
@ 2019-04-25 12:34 Niklas Cassel
2019-04-27 4:53 ` Bjorn Andersson
0 siblings, 1 reply; 2+ messages in thread
From: Niklas Cassel @ 2019-04-25 12:34 UTC (permalink / raw)
To: Andy Gross, David Brown, Rob Herring, Mark Rutland
Cc: linux-arm-msm, Niklas Cassel, devicetree, linux-kernel
The current l3 min voltage level is not supported by
the regulator (the voltage is not a multiple of the regulator step size),
so a driver requesting this exact voltage would fail, see discussion in:
https://patchwork.kernel.org/comment/22461199/
It was agreed upon to set a min voltage level that is a multiple of the
regulator step size.
There was actually a patch sent that did this:
https://patchwork.kernel.org/patch/10819313/
However, the commit 331ab98f8c4a ("arm64: dts: qcom: qcs404:
Fix voltages l3") that was applied is not identical to that patch.
Signed-off-by: Niklas Cassel <niklas.cassel@linaro.org>
---
arch/arm64/boot/dts/qcom/qcs404-evb.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/qcs404-evb.dtsi b/arch/arm64/boot/dts/qcom/qcs404-evb.dtsi
index 6910fc663fe1..9a7d930dcd23 100644
--- a/arch/arm64/boot/dts/qcom/qcs404-evb.dtsi
+++ b/arch/arm64/boot/dts/qcom/qcs404-evb.dtsi
@@ -118,7 +118,7 @@
};
vreg_l3_1p05: l3 {
- regulator-min-microvolt = <1050000>;
+ regulator-min-microvolt = <1048000>;
regulator-max-microvolt = <1160000>;
};
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] arm64: dts: qcom: qcs404-evb: fix l3 min voltage
2019-04-25 12:34 [PATCH] arm64: dts: qcom: qcs404-evb: fix l3 min voltage Niklas Cassel
@ 2019-04-27 4:53 ` Bjorn Andersson
0 siblings, 0 replies; 2+ messages in thread
From: Bjorn Andersson @ 2019-04-27 4:53 UTC (permalink / raw)
To: Niklas Cassel
Cc: Andy Gross, David Brown, Rob Herring, Mark Rutland, linux-arm-msm,
devicetree, linux-kernel
On Thu 25 Apr 05:34 PDT 2019, Niklas Cassel wrote:
> The current l3 min voltage level is not supported by
> the regulator (the voltage is not a multiple of the regulator step size),
> so a driver requesting this exact voltage would fail, see discussion in:
> https://patchwork.kernel.org/comment/22461199/
>
> It was agreed upon to set a min voltage level that is a multiple of the
> regulator step size.
>
> There was actually a patch sent that did this:
> https://patchwork.kernel.org/patch/10819313/
>
> However, the commit 331ab98f8c4a ("arm64: dts: qcom: qcs404:
> Fix voltages l3") that was applied is not identical to that patch.
>
> Signed-off-by: Niklas Cassel <niklas.cassel@linaro.org>
Thanks for spotting and sorting this out, picked up.
Regards,
Bjorn
> ---
> arch/arm64/boot/dts/qcom/qcs404-evb.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/qcs404-evb.dtsi b/arch/arm64/boot/dts/qcom/qcs404-evb.dtsi
> index 6910fc663fe1..9a7d930dcd23 100644
> --- a/arch/arm64/boot/dts/qcom/qcs404-evb.dtsi
> +++ b/arch/arm64/boot/dts/qcom/qcs404-evb.dtsi
> @@ -118,7 +118,7 @@
> };
>
> vreg_l3_1p05: l3 {
> - regulator-min-microvolt = <1050000>;
> + regulator-min-microvolt = <1048000>;
> regulator-max-microvolt = <1160000>;
> };
>
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-04-27 4:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-04-25 12:34 [PATCH] arm64: dts: qcom: qcs404-evb: fix l3 min voltage Niklas Cassel
2019-04-27 4:53 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).