From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH v2 1/2] dt-binding: misc: Add common LPC snoop documentation Date: Mon, 29 Apr 2019 17:58:47 -0500 Message-ID: <20190429225847.GA8905@bogus> References: <20190416111631.356803-1-tmaimon77@gmail.com> <20190416111631.356803-2-tmaimon77@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20190416111631.356803-2-tmaimon77@gmail.com> Sender: linux-kernel-owner@vger.kernel.org To: Tomer Maimon Cc: gregkh@linuxfoundation.org, arnd@arnd.de, mark.rutland@arm.com, yuenn@google.com, venture@google.com, brendanhiggins@google.com, avifishman70@gmail.com, joel@jms.id.au, linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org, openbmc@lists.ozlabs.org, linux-kernel@vger.kernel.org List-Id: devicetree@vger.kernel.org On Tue, Apr 16, 2019 at 02:16:30PM +0300, Tomer Maimon wrote: > Added device tree binding documentation for Nuvoton BMC > NPCM BIOS Post Code (BPC) and Apeed AST2500 LPC snoop. s/Apeed/Aspeed/ > The LPC snoop monitoring two configurable I/O addresses > written by the host on Low Pin Count (LPC) bus. > > Signed-off-by: Tomer Maimon > Reviewed-by: Andrew Jeffery > --- > .../devicetree/bindings/misc/lpc-snoop.txt | 27 ++++++++++++++++++++++ > 1 file changed, 27 insertions(+) > create mode 100644 Documentation/devicetree/bindings/misc/lpc-snoop.txt > > diff --git a/Documentation/devicetree/bindings/misc/lpc-snoop.txt b/Documentation/devicetree/bindings/misc/lpc-snoop.txt > new file mode 100644 > index 000000000000..c21cb8df4ffb > --- /dev/null > +++ b/Documentation/devicetree/bindings/misc/lpc-snoop.txt > @@ -0,0 +1,27 @@ > +LPC snoop interface > + > +The LPC snoop (BIOS Post Code) interface can monitor > +two configurable I/O addresses written by the host on > +the Low Pin Count (LPC) bus. > + > +Nuvoton NPCM7xx LPC snoop supports capture double words, > +when using capture double word only I/O address 1 is monitored. > + > +Required properties for lpc-snoop node > +- compatible : "nuvoton,npcm750-lpc-bpc-snoop" for Poleg NPCM7XX > + "aspeed,ast2500-lpc-snoop" for Aspeed AST2500. > +- reg : specifies physical base address and size of the registers. > +- interrupts : contain the LPC snoop interrupt with flags for falling edge. > +- snoop-ports : contain monitor I/O addresses, at least one monitor I/O > + address required > + > +Optional property for NPCM7xx lpc-snoop node > +- nuvoton,lpc-en-dwcapture : enable capture double words support. > + > +Example: > + lpc-snoop: lpc_snoop@f0007040 { lpc-snoop@... With that, Reviewed-by: Rob Herring > + compatible = "nuvoton,npcm750-lpc-bpc-snoop"; > + reg = <0xf0007040 0x14>; > + snoop-ports = <0x80>; > + interrupts = ; > + }; > -- > 2.14.1 >