From: Phong Tran <tranmanphong@gmail.com>
To: robh+dt@kernel.org, frowand.list@gmail.com,
pantelis.antoniou@konsulko.com
Cc: David.Laight@ACULAB.COM, hch@infradead.org,
ndesaulniers@google.com, natechancellor@gmail.com,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
clang-built-linux@googlegroups.com,
Phong Tran <tranmanphong@gmail.com>
Subject: [PATCH V2] of: fix clang -Wunsequenced for be32_to_cpu()
Date: Tue, 30 Apr 2019 21:56:24 +0700 [thread overview]
Message-ID: <20190430145624.30470-1-tranmanphong@gmail.com> (raw)
In-Reply-To: <46b3e8edf27e4c8f98697f9e7f2117d6@AcuMS.aculab.com>
Now, make the loop explicit to avoid clang warning.
./include/linux/of.h:238:37: warning: multiple unsequenced modifications
to 'cell' [-Wunsequenced]
r = (r << 32) | be32_to_cpu(*(cell++));
^~
./include/linux/byteorder/generic.h:95:21: note: expanded from macro
'be32_to_cpu'
^
./include/uapi/linux/byteorder/little_endian.h:40:59: note: expanded
from macro '__be32_to_cpu'
^
./include/uapi/linux/swab.h:118:21: note: expanded from macro '__swab32'
___constant_swab32(x) : \
^
./include/uapi/linux/swab.h:18:12: note: expanded from macro
'___constant_swab32'
(((__u32)(x) & (__u32)0x000000ffUL) << 24) | \
^
Signed-off-by: Phong Tran <tranmanphong@gmail.com>
---
include/linux/of.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/of.h b/include/linux/of.h
index e240992e5cb6..71ca25ac01f6 100644
--- a/include/linux/of.h
+++ b/include/linux/of.h
@@ -234,8 +234,8 @@ extern struct device_node *of_find_all_nodes(struct device_node *prev);
static inline u64 of_read_number(const __be32 *cell, int size)
{
u64 r = 0;
- while (size--)
- r = (r << 32) | be32_to_cpu(*(cell++));
+ for(; size--; cell++)
+ r = (r << 32) | be32_to_cpu(*cell);
return r;
}
--
2.21.0
next prev parent reply other threads:[~2019-04-30 14:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-30 9:00 [PATCH] of: replace be32_to_cpu to be32_to_cpup Phong Tran
2019-04-30 9:37 ` Nathan Chancellor
2019-04-30 10:52 ` David Laight
2019-04-30 14:56 ` Phong Tran [this message]
2019-04-30 16:28 ` [PATCH V2] of: fix clang -Wunsequenced for be32_to_cpu() Nick Desaulniers
2019-04-30 16:29 ` Nick Desaulniers
2019-05-01 18:13 ` Nick Desaulniers
2019-05-01 19:33 ` Rob Herring
2019-04-30 13:32 ` [PATCH] of: replace be32_to_cpu to be32_to_cpup Christoph Hellwig
2019-04-30 14:44 ` Phong Tran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190430145624.30470-1-tranmanphong@gmail.com \
--to=tranmanphong@gmail.com \
--cc=David.Laight@ACULAB.COM \
--cc=clang-built-linux@googlegroups.com \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=natechancellor@gmail.com \
--cc=ndesaulniers@google.com \
--cc=pantelis.antoniou@konsulko.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).