From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guido =?iso-8859-1?Q?G=FCnther?= Subject: Re: [PATCH] arm64: dts: imx8mq: Add a node for irqsteer Date: Tue, 30 Apr 2019 19:16:57 +0200 Message-ID: <20190430171657.GA1513@bogon.m.sigxcpu.org> References: <1556632204.2560.20.camel@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: <1556632204.2560.20.camel@pengutronix.de> Sender: linux-kernel-owner@vger.kernel.org To: Lucas Stach Cc: Rob Herring , Mark Rutland , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Abel Vesa , Carlo Caione , Daniel Baluta , "Angus Ainslie (Purism)" , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org List-Id: devicetree@vger.kernel.org Hi Lucas, On Tue, Apr 30, 2019 at 03:50:04PM +0200, Lucas Stach wrote: > Am Dienstag, den 30.04.2019, 15:41 +0200 schrieb Guido Günther: > > Add a node for the irqsteer interrupt controller found on the iMX8MQ > > SoC. > > > > Signed-off-by: Guido Günther > > --- > >  arch/arm64/boot/dts/freescale/imx8mq.dtsi | 21 +++++++++++++++++++++ > >  1 file changed, 21 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi > > index 2cc939cfbd75..ce0e137ec8ee 100644 > > --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi > > +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi > > @@ -798,6 +798,27 @@ > >   }; > >   }; > >   > > + bus@32c00000 { /* AIPS4 */ > > + compatible = "fsl,imx8mq-aips-bus", "simple-bus"; > > + #address-cells = <1>; > > + #size-cells = <1>; > > + ranges = <0x32c00000 0x32c00000 0x400000>; > > + > > + irqsteer: interrupt-controller@32e2d000 { > > + compatible = "fsl,imx8m-irqsteer", > > +      "fsl,imx-irqsteer"; > > This fits on a single line, right? It went past the 80 char limit but it seems the dts is not super picky about that so I changed that in v2. > > > + reg = <0x32e2d000 0x1000>; > > + interrupts = ; > > + clocks = <&clk IMX8MQ_CLK_DISP_APB_ROOT>; > > + clock-names = "ipg"; > > + fsl,channel = <0>; > > + fsl,num-irqs = <64>; > > + interrupt-controller; > > + interrupt-parent = <&gic>; > > This is wrong, the irqsteer upstream IRQ is routed through the GPC like > all the other peripheral interrupts. You can just drop this property. Fixed in v2. Thanks, -- Guido > > With this fixed: > Reviewed-by: Lucas Stach > > Regards, > Lucas > > > + #interrupt-cells = <1>; > > + }; > > + }; > > + > >   gpu: gpu@38000000 { > >   compatible = "vivante,gc"; > >   reg = <0x38000000 0x40000>; >