From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Jeffrey Hugo <jhugo@codeaurora.org>
Cc: agross@kernel.org, david.brown@linaro.org,
marc.w.gonzalez@free.fr, mturquette@baylibre.com,
sboyd@kernel.org, robh+dt@kernel.org, mark.rutland@arm.com,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v3 6/6] arm64: dts: qcom: msm8998: Add mmcc node
Date: Tue, 30 Apr 2019 20:44:06 -0700 [thread overview]
Message-ID: <20190501034406.GF2938@tuxbook-pro> (raw)
In-Reply-To: <1556677679-29465-1-git-send-email-jhugo@codeaurora.org>
On Tue 30 Apr 19:27 PDT 2019, Jeffrey Hugo wrote:
> Add MSM8998 Multimedia Clock Controller DT node.
>
> Signed-off-by: Jeffrey Hugo <jhugo@codeaurora.org>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
(But same comment as earlier wrt clocks vs clock-names ordering)
Regards,
Bjorn
> ---
> arch/arm64/boot/dts/qcom/msm8998.dtsi | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/msm8998.dtsi b/arch/arm64/boot/dts/qcom/msm8998.dtsi
> index 9c88801..5b63fa2 100644
> --- a/arch/arm64/boot/dts/qcom/msm8998.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8998.dtsi
> @@ -3,6 +3,7 @@
>
> #include <dt-bindings/interrupt-controller/arm-gic.h>
> #include <dt-bindings/clock/qcom,gcc-msm8998.h>
> +#include <dt-bindings/clock/qcom,mmcc-msm8998.h>
> #include <dt-bindings/clock/qcom,rpmcc.h>
> #include <dt-bindings/gpio/gpio.h>
>
> @@ -1066,6 +1067,19 @@
> status = "disabled";
> };
>
> + mmcc: clock-controller@c8c0000 {
> + compatible = "qcom,mmcc-msm8998";
> + #clock-cells = <1>;
> + #reset-cells = <1>;
> + #power-domain-cells = <1>;
> + reg = <0x0c8c0000 0x40000>;
> +
> + clock-names = "xo",
> + "gpll0";
> + clocks = <&rpmcc RPM_SMD_XO_CLK_SRC>,
> + <&gcc GPLL0_OUT_MAIN>;
> + };
> +
> timer@17920000 {
> #address-cells = <1>;
> #size-cells = <1>;
> --
> Qualcomm Datacenter Technologies as an affiliate of Qualcomm Technologies, Inc.
> Qualcomm Technologies, Inc. is a member of the
> Code Aurora Forum, a Linux Foundation Collaborative Project.
>
prev parent reply other threads:[~2019-05-01 3:44 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-01 2:23 [PATCH v3 0/6] MSM8998 Multimedia Clock Controller Jeffrey Hugo
2019-05-01 2:24 ` [PATCH v3 1/6] dt-bindings: clock: Document external clocks for MSM8998 gcc Jeffrey Hugo
2019-05-01 3:34 ` Bjorn Andersson
2019-05-01 14:17 ` Jeffrey Hugo
2019-05-01 19:48 ` Rob Herring
2019-05-01 2:25 ` [PATCH v3 2/6] arm64: dts: msm8998: Add xo clock to gcc node Jeffrey Hugo
2019-05-01 3:35 ` Bjorn Andersson
2019-05-01 14:17 ` Jeffrey Hugo
2019-05-01 2:26 ` [PATCH v3 3/6] clk: qcom: smd: Add XO clock for MSM8998 Jeffrey Hugo
2019-05-01 3:26 ` Bjorn Andersson
2019-05-01 2:26 ` [PATCH v3 4/6] dt-bindings: clock: Add support for the MSM8998 mmcc Jeffrey Hugo
2019-05-01 3:37 ` Bjorn Andersson
2019-05-01 2:27 ` [PATCH v3 5/6] clk: qcom: Add MSM8998 Multimedia Clock Controller (MMCC) driver Jeffrey Hugo
2019-05-01 3:43 ` Bjorn Andersson
2019-05-01 14:25 ` Jeffrey Hugo
2019-05-01 16:54 ` Bjorn Andersson
2019-05-01 2:27 ` [PATCH v3 6/6] arm64: dts: qcom: msm8998: Add mmcc node Jeffrey Hugo
2019-05-01 3:44 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190501034406.GF2938@tuxbook-pro \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jhugo@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.w.gonzalez@free.fr \
--cc=mark.rutland@arm.com \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).