From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH V2 1/4] dt-bindings: fsl: scu: add watchdog binding Date: Wed, 1 May 2019 15:10:10 -0500 Message-ID: <20190501201010.GA7249@bogus> References: <1556421727-7401-1-git-send-email-Anson.Huang@nxp.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1556421727-7401-1-git-send-email-Anson.Huang@nxp.com> Sender: linux-kernel-owner@vger.kernel.org To: Anson Huang Cc: "mark.rutland@arm.com" , "wim@linux-watchdog.org" , "linux@roeck-us.net" , "shawnguo@kernel.org" , "s.hauer@pengutronix.de" , "kernel@pengutronix.de" , "festevam@gmail.com" , Aisheng Dong , "ulf.hansson@linaro.org" , Peng Fan , Daniel Baluta , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-watchdog@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" List-Id: devicetree@vger.kernel.org On Sun, Apr 28, 2019 at 03:27:00AM +0000, Anson Huang wrote: > i.MX system controller watchdog has pretimeout function which > depends on i.MX SCU driver, so watchdog DT node needs to be > subnode of SCU, this patch adds i.MX system controller watchdog > binding to SCU binding doc. > > Signed-off-by: Anson Huang > --- > New patch. > --- > .../devicetree/bindings/arm/freescale/fsl,scu.txt | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt > index 5d7dbab..1b56557 100644 > --- a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt > +++ b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt > @@ -133,6 +133,16 @@ RTC bindings based on SCU Message Protocol > Required properties: > - compatible: should be "fsl,imx8qxp-sc-rtc"; > > +Watchdog bindings based on SCU Message Protocol > +------------------------------------------------------------ > + > +Required properties: > +- compatible: should be: > + "fsl,imx8qxp-sc-wdt" > + followed by "fsl,imx-sc-wdt"; > +Optional properties: > +- timeout-sec: contains the watchdog timeout in seconds. This should be the time to reset the system, but the subject talks about the pre-timeout which I guess is just an interrupt. If it is pre-timeout you want add a new property and don't abuse the existing one. Rob