From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [RFC PATCH V1 3/6] dt-bindings: mt8183: Added FD dt-bindings Date: Wed, 1 May 2019 17:46:47 -0500 Message-ID: <20190501224647.GA12044@bogus> References: <20190423104505.38778-1-Jerry-Ch.chen@mediatek.com> <20190423104505.38778-4-Jerry-Ch.chen@mediatek.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20190423104505.38778-4-Jerry-Ch.chen@mediatek.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Jerry-ch Chen Cc: devicetree@vger.kernel.org, Sean.Cheng@mediatek.com, laurent.pinchart+renesas@ideasonboard.com, Rynn.Wu@mediatek.com, christie.yu@mediatek.com, srv_heupstream@mediatek.com, holmes.chiou@mediatek.com, suleiman@chromium.org, shik@chromium.org, tfiga@chromium.org, jungo.lin@mediatek.com, sj.huang@mediatek.com, yuzhao@chromium.org, hans.verkuil@cisco.com, zwisler@chromium.org, frederic.chen@mediatek.com, matthias.bgg@gmail.com, linux-mediatek@lists.infradead.org, mchehab@kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org List-Id: devicetree@vger.kernel.org On Tue, Apr 23, 2019 at 06:45:02PM +0800, Jerry-ch Chen wrote: > From: Jerry-ch Chen > > This patch adds DT binding documentation for the Face Detection (FD) > unit of the camera system on Mediatek's SoCs. > > Signed-off-by: Jerry-ch Chen > --- > .../bindings/media/mediatek,mt8183-fd.txt | 34 +++++++++++++++++++ > 1 file changed, 34 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/mediatek,mt8183-fd.txt > > diff --git a/Documentation/devicetree/bindings/media/mediatek,mt8183-fd.txt b/Documentation/devicetree/bindings/media/mediatek,mt8183-fd.txt > new file mode 100644 > index 000000000000..97c12fd93e7e > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/mediatek,mt8183-fd.txt > @@ -0,0 +1,34 @@ > +* Mediatek Face Detection Unit (FD) > + > +Face Detection (FD) unit is a typical memory-to-memory HW device. > +It provides hardware accelerated face detection function, and it > +is able to detect different poses of faces. FD will writre result > +of detected face into memory as output. > + > +Required properties: > +- compatible: "mediatek,mt8183-fd" > +- reg: Physical base address and length of the function block register space > +- interrupts: interrupt number to the cpu. > +- iommus: should point to the respective IOMMU block with master port as > + argument, see Documentation/devicetree/bindings/iommu/mediatek,iommu.txt > + for details. How many entries? Looks like 3 from the example. > +- mediatek,larb: must contain the local arbiters in the current Socs, see > + Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.txt > + for details. > +- clocks : must contain the FDVT clock > +- clock-names: must contain FD_CLK_IMG_FD > + > +Example: > + fd:fd@1502b000 { ^ space needed > + compatible = "mediatek,mt8183-fd"; > + mediatek,larb = <&larb5>; > + mediatek,scp = <&scp>; > + iommus = <&iommu M4U_PORT_CAM_FDVT_RP>, > + <&iommu M4U_PORT_CAM_FDVT_WR>, > + <&iommu M4U_PORT_CAM_FDVT_RB>; > + reg = <0 0x1502b000 0 0x1000>; > + interrupts = ; > + clocks = <&imgsys CLK_IMG_FDVT>; > + clock-names = "FD_CLK_IMG_FD"; > + }; > + > -- > 2.18.0 >