From: Maxime Ripard <maxime.ripard-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org>
To: Icenowy Zheng <icenowy-h8G6r0blFSE@public.gmane.org>
Cc: Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
Subject: Re: [PATCH] arm64: dts: allwinner: h6: add PIO VCC bank supplies for Pine H64
Date: Thu, 2 May 2019 09:43:03 +0200 [thread overview]
Message-ID: <20190502074303.g3px63n4v4o7xade@flea> (raw)
In-Reply-To: <20190424062543.61852-1-icenowy-h8G6r0blFSE@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 698 bytes --]
Hi,
On Wed, Apr 24, 2019 at 02:25:43PM +0800, Icenowy Zheng wrote:
> The Allwinner H6 SoC features tweakable VCC for PC, PD, PG, PL and PM
> banks.
>
> This patch adds supplies for PC and PD banks on Pine H64 board. PG and
> PM banks are used for Wi-Fi and should be added when Wi-Fi is added
Not really. The regulator is still there, whether we use it or not. If
it's not used, then it will be left disabled so it doesn't really
change anything.
> PL bank is where PMIC is attached, and currently if a PMIC regulator
> is added for it a dependency loop will happen.
I guess we should fix that somehow
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2019-05-02 7:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-24 6:25 [PATCH] arm64: dts: allwinner: h6: add PIO VCC bank supplies for Pine H64 Icenowy Zheng
[not found] ` <20190424062543.61852-1-icenowy-h8G6r0blFSE@public.gmane.org>
2019-05-02 7:43 ` Maxime Ripard [this message]
2019-05-02 7:46 ` Icenowy Zheng
[not found] ` <8CB1EDA4-E4B7-486D-8BCD-884E0025C6EA-h8G6r0blFSE@public.gmane.org>
2019-05-02 18:10 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190502074303.g3px63n4v4o7xade@flea \
--to=maxime.ripard-ldxbnhwyfcjbdgjk7y7tuq@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=icenowy-h8G6r0blFSE@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org \
--cc=wens-jdAy2FN1RRM@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).