devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Dragan Cvetic <dragan.cvetic@xilinx.com>
Cc: arnd@arndb.de, michal.simek@xilinx.com,
	linux-arm-kernel@lists.infradead.org, robh+dt@kernel.org,
	mark.rutland@arm.com, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Derek Kiernan <derek.kiernan@xilinx.com>
Subject: Re: [PATCH V3 02/12] misc: xilinx-sdfec: add core driver
Date: Thu, 2 May 2019 19:20:07 +0200	[thread overview]
Message-ID: <20190502172007.GA1874@kroah.com> (raw)
In-Reply-To: <1556402706-176271-3-git-send-email-dragan.cvetic@xilinx.com>

On Sat, Apr 27, 2019 at 11:04:56PM +0100, Dragan Cvetic wrote:
> +#define DRIVER_NAME "xilinx_sdfec"
> +#define DRIVER_VERSION "0.3"

Version means nothing with the driver in the kernel tree, please remove
it.

> +#define DRIVER_MAX_DEV BIT(MINORBITS)

Why this number?  Why limit yourself to any number?

> +
> +static struct class *xsdfec_class;

Do you really need your own class?

> +static atomic_t xsdfec_ndevs = ATOMIC_INIT(0);

Why?

> +static dev_t xsdfec_devt;

Why?

Why not use misc_device for this?  Why do you need your own major with a
bunch of minor devices reserved ahead of time?  Why not just create a
new misc device for every individual device that happens to be found in
the system?  That will make the code a lot simpler and smaller and
easier.



> +
> +/**
> + * struct xsdfec_dev - Driver data for SDFEC
> + * @regs: device physical base address
> + * @dev: pointer to device struct
> + * @config: Configuration of the SDFEC device
> + * @open_count: Count of char device being opened
> + * @xsdfec_cdev: Character device handle
> + * @irq_lock: Driver spinlock
> + *
> + * This structure contains necessary state for SDFEC driver to operate
> + */
> +struct xsdfec_dev {
> +	void __iomem *regs;
> +	struct device *dev;
> +	struct xsdfec_config config;
> +	atomic_t open_count;
> +	struct cdev xsdfec_cdev;
> +	/* Spinlock to protect state_updated and stats_updated */
> +	spinlock_t irq_lock;
> +};
> +
> +static const struct file_operations xsdfec_fops = {
> +	.owner = THIS_MODULE,
> +};

No operations at all?  That's an easy driver :)

thanks,

greg k-h

  reply	other threads:[~2019-05-02 17:20 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-27 22:04 [PATCH V3 00/12] misc: xilinx sd-fec drive Dragan Cvetic
2019-04-27 22:04 ` [PATCH V3 01/12] dt-bindings: xilinx-sdfec: Add SDFEC binding Dragan Cvetic
2019-05-01 19:47   ` Rob Herring
2019-05-02 11:04     ` Dragan Cvetic
2019-05-02 20:15       ` Rob Herring
2019-05-03 17:04         ` Dragan Cvetic
2019-04-27 22:04 ` [PATCH V3 02/12] misc: xilinx-sdfec: add core driver Dragan Cvetic
2019-05-02 17:20   ` Greg KH [this message]
2019-05-03 16:41     ` Dragan Cvetic
2019-05-04  7:55       ` Greg KH
2019-05-06 12:23         ` Dragan Cvetic
2019-05-06 12:34           ` Greg KH
2019-05-07  8:48             ` Dragan Cvetic
2019-05-07  9:39               ` Greg KH
2019-05-07 11:55                 ` Dragan Cvetic
2019-05-07 12:21                   ` Greg KH
2019-05-07 13:15                     ` Dragan Cvetic
2019-04-27 22:04 ` [PATCH V3 03/12] misc: xilinx_sdfec: Add CCF support Dragan Cvetic
2019-04-27 22:04 ` [PATCH V3 04/12] misc: xilinx_sdfec: Add open, close and ioctl Dragan Cvetic
2019-05-02 17:23   ` Greg KH
2019-05-03 16:44     ` Dragan Cvetic
2019-05-04  9:02       ` Greg KH
2019-05-02 17:23   ` Greg KH
2019-05-03 16:46     ` Dragan Cvetic
2019-05-04  9:01       ` Greg KH
2019-05-04 14:35     ` Arnd Bergmann
2019-05-04 14:41       ` Greg KH
2019-04-27 22:04 ` [PATCH V3 05/12] misc: xilinx_sdfec: Store driver config and state Dragan Cvetic
2019-04-27 22:05 ` [PATCH V3 06/12] misc: xilinx_sdfec: Add ability to configure turbo Dragan Cvetic
2019-04-27 22:05 ` [PATCH V3 07/12] misc: xilinx_sdfec: Add ability to configure LDPC Dragan Cvetic
2019-05-02 17:27   ` Greg KH
2019-05-03 16:49     ` Dragan Cvetic
2019-05-04  9:00       ` Greg KH
2019-04-27 22:05 ` [PATCH V3 08/12] misc: xilinx_sdfec: Add ability to get/set config Dragan Cvetic
2019-04-27 22:05 ` [PATCH V3 09/12] misc: xilinx_sdfec: Support poll file operation Dragan Cvetic
2019-04-27 22:05 ` [PATCH V3 10/12] misc: xilinx_sdfec: Add stats & status ioctls Dragan Cvetic
2019-04-27 22:05 ` [PATCH V3 11/12] Docs: misc: xilinx_sdfec: Add documentation Dragan Cvetic
2019-04-27 22:05 ` [PATCH V3 12/12] MAINTAINERS: add maintainer for SD-FEC Dragan Cvetic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190502172007.GA1874@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=arnd@arndb.de \
    --cc=derek.kiernan@xilinx.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dragan.cvetic@xilinx.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=michal.simek@xilinx.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).