devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Michael Tretter <m.tretter@pengutronix.de>
To: linux-media@vger.kernel.org, devicetree@vger.kernel.org
Cc: kernel@pengutronix.de, robh+dt@kernel.org, mchehab@kernel.org,
	tfiga@chromium.org, dshah@xilinx.com, hverkuil@xs4all.nl,
	Hans Verkuil <hverkuil-cisco@xs4all.nl>
Subject: [PATCH v5 1/5] videobuf2-v4l2: set last_buffer_dequeued in dqbuf
Date: Fri,  3 May 2019 14:20:06 +0200	[thread overview]
Message-ID: <20190503122010.16663-2-m.tretter@pengutronix.de> (raw)
In-Reply-To: <20190503122010.16663-1-m.tretter@pengutronix.de>

From: Hans Verkuil <hverkuil-cisco@xs4all.nl>

last_buffer_dequeued was set to true in __fill_v4l2_buffer, but this
is called for qbuf as well. Move it to vb2_dqbuf.

Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
---
 drivers/media/common/videobuf2/videobuf2-v4l2.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/media/common/videobuf2/videobuf2-v4l2.c b/drivers/media/common/videobuf2/videobuf2-v4l2.c
index fb9ac7696fc6..40d76eb4c2fe 100644
--- a/drivers/media/common/videobuf2/videobuf2-v4l2.c
+++ b/drivers/media/common/videobuf2/videobuf2-v4l2.c
@@ -563,11 +563,6 @@ static void __fill_v4l2_buffer(struct vb2_buffer *vb, void *pb)
 		b->flags |= V4L2_BUF_FLAG_REQUEST_FD;
 		b->request_fd = vbuf->request_fd;
 	}
-
-	if (!q->is_output &&
-		b->flags & V4L2_BUF_FLAG_DONE &&
-		b->flags & V4L2_BUF_FLAG_LAST)
-		q->last_buffer_dequeued = true;
 }
 
 /*
@@ -786,6 +781,11 @@ int vb2_dqbuf(struct vb2_queue *q, struct v4l2_buffer *b, bool nonblocking)
 
 	ret = vb2_core_dqbuf(q, NULL, b, nonblocking);
 
+	if (!q->is_output &&
+	    b->flags & V4L2_BUF_FLAG_DONE &&
+	    b->flags & V4L2_BUF_FLAG_LAST)
+		q->last_buffer_dequeued = true;
+
 	/*
 	 *  After calling the VIDIOC_DQBUF V4L2_BUF_FLAG_DONE must be
 	 *  cleared.
-- 
2.20.1

  reply	other threads:[~2019-05-03 12:20 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-03 12:20 [PATCH v5 0/5] Add ZynqMP VCU/Allegro DVT H.264 encoder driver Michael Tretter
2019-05-03 12:20 ` Michael Tretter [this message]
2019-05-03 12:20 ` [PATCH v5 2/5] media: dt-bindings: media: document allegro-dvt bindings Michael Tretter
2019-05-03 12:20 ` [PATCH v5 3/5] media: dt-bindings: media: Add vendor prefix for allegro Michael Tretter
2019-05-07 17:08   ` Rob Herring
2019-05-03 12:20 ` [PATCH v5 4/5] [media] allegro: add Allegro DVT video IP core driver Michael Tretter
2019-05-04 11:40   ` kbuild test robot
2019-05-04 11:40   ` [RFC PATCH] allegro: allegro_alloc_buffer() can be static kbuild test robot
2019-05-10  8:28   ` [PATCH v5 4/5] [media] allegro: add Allegro DVT video IP core driver Hans Verkuil
2019-05-10 10:28     ` Michael Tretter
2019-05-10 10:58       ` Hans Verkuil
2019-05-10 13:52         ` Michael Tretter
2019-05-10 14:11           ` Hans Verkuil
2019-05-10 14:58             ` Michael Tretter
2019-05-10 10:49     ` Philipp Zabel
2019-05-03 12:20 ` [PATCH v5 5/5] [media] allegro: add SPS/PPS nal unit writer Michael Tretter
2019-05-04 12:25   ` [RFC PATCH] allegro: nal_h264_write_start_code_prefix() can be static kbuild test robot
2019-05-04 12:25   ` [PATCH v5 5/5] [media] allegro: add SPS/PPS nal unit writer kbuild test robot
2019-05-06 10:24   ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190503122010.16663-2-m.tretter@pengutronix.de \
    --to=m.tretter@pengutronix.de \
    --cc=devicetree@vger.kernel.org \
    --cc=dshah@xilinx.com \
    --cc=hverkuil-cisco@xs4all.nl \
    --cc=hverkuil@xs4all.nl \
    --cc=kernel@pengutronix.de \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=tfiga@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).