From: Pavel Machek <pavel@ucw.cz>
To: Jacek Anaszewski <jacek.anaszewski@gmail.com>
Cc: Christian Mauderer <list@c-mauderer.de>,
oss@c-mauderer.de, linux-leds@vger.kernel.org,
devicetree@vger.kernel.org, Dan Murphy <dmurphy@ti.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>
Subject: Re: [PATCH 1/2] dt-bindings: leds: Add binding for ubnt-spi LED.
Date: Sat, 4 May 2019 22:34:48 +0200 [thread overview]
Message-ID: <20190504203448.GA24856@amd> (raw)
In-Reply-To: <5cc8907f-5cb4-e8b4-7309-cc446ef5bde7@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1227 bytes --]
Hi!
> >I wasn't aware of that list. Maybe "power" or even better "status" would
> >match the function.
>
> Hmm, I've just found out that there are two "wlan-ap" occurrences in
> the existing mainline bindings, so I propose to follow that.
>
> >Should I add the color too? So "white:status"?
>
> Yes, why not if it is known. So, having the above I propose:
>
> label = "white:wlan-ap";
Linux now runs on many different devices, and I believe userland wants
to know "this is main notification LED for this device" (and the only
one in this case).
Phones normally have at most one such LED. Now access point. Someone
will make ethernet switch with just one LED. Maybe thermostat will
have only one LED. Bluetooth GPS. ...
I'd prefer not to mention type of device, and simply state that this
is status LED for the device. Droid 4 uses
"status-led:{red,green,blue}", so "status-led:white" would seem
reasonable.
"white:status" sounds good, too. But I'd prefer not to mention type of
the device, it is simply status LED.
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2019-05-04 20:34 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-04 12:28 [PATCH 1/2] dt-bindings: leds: Add binding for ubnt-spi LED list
2019-05-04 12:28 ` [PATCH 2/2] leds: ubnt-spi: Add Ubnt AirCube ISP LED driver list
2019-05-04 16:20 ` Pavel Machek
2019-05-04 16:43 ` Christian Mauderer
2019-05-04 17:25 ` Pavel Machek
2019-05-04 16:12 ` [PATCH 1/2] dt-bindings: leds: Add binding for ubnt-spi LED Pavel Machek
2019-05-04 16:46 ` Christian Mauderer
2019-05-04 19:34 ` Jacek Anaszewski
2019-05-04 19:45 ` Jacek Anaszewski
2019-05-04 20:01 ` Christian Mauderer
2019-05-04 20:07 ` Jacek Anaszewski
2019-05-04 19:48 ` Christian Mauderer
2019-05-04 20:01 ` Jacek Anaszewski
2019-05-04 20:34 ` Pavel Machek [this message]
2019-05-04 22:17 ` Pavel Machek
2019-05-05 8:01 ` Christian Mauderer
2019-05-05 10:56 ` Jacek Anaszewski
2019-05-05 11:51 ` Christian Mauderer
2019-05-05 12:15 ` Jacek Anaszewski
2019-05-05 11:54 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190504203448.GA24856@amd \
--to=pavel@ucw.cz \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-leds@vger.kernel.org \
--cc=list@c-mauderer.de \
--cc=mark.rutland@arm.com \
--cc=oss@c-mauderer.de \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).