From: Oleksij Rempel <o.rempel@pengutronix.de>
To: Chuanhong Guo <gch981213@gmail.com>
Cc: Andrew Lunn <andrew@lunn.ch>, Paul Burton <paul.burton@mips.com>,
Ralf Baechle <ralf@linux-mips.org>,
James Hogan <jhogan@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Jay Cliburn <jcliburn@gmail.com>,
Chris Snook <chris.snook@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Mark Rutland <mark.rutland@arm.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
linux-mips@vger.kernel.org,
open list <linux-kernel@vger.kernel.org>,
devicetree@vger.kernel.org, John Crispin <john@phrozen.org>,
Felix Fietkau <nbd@nbd.name>,
netdev@vger.kernel.org
Subject: Re: [PATCH v3 3/3] net: ethernet: add ag71xx driver
Date: Sun, 5 May 2019 07:41:19 +0200 [thread overview]
Message-ID: <20190505054119.ac3jxtonkpn4pszn@pengutronix.de> (raw)
In-Reply-To: <CAJsYDVJ84RsNVe9Mj9sYYwwLmmMkinRSJW4ziW22Sf04wS5gyw@mail.gmail.com>
On Sat, May 04, 2019 at 11:40:53PM +0800, Chuanhong Guo wrote:
> Hi!
>
> On Mon, Apr 22, 2019 at 9:28 PM Andrew Lunn <andrew@lunn.ch> wrote:
> > [...]
> > > + /*
> > > + * On most (all?) Atheros/QCA SoCs dual eth interfaces are not equal.
> > > + *
> > > + * That is to say eth0 can not work independently. It only works
> > > + * when eth1 is working.
> > > + */
> >
> > Please could you explain that some more? Is there just one MDIO bus
> > shared by two ethernet controllers? If so, it would be better to have
> > the MDIO bus controller as a separate driver.
>
> mdio registers exists on both ethernet blocks. And due to how reset
> works on this ethernet IP, it's hard to split it into a separated
> driver. (Only asserting both eth and mdio resets together will reset
> everything including register values.)
> The reason why gmac1 should be brought up first is that on some chips,
> mdio on gmac0 connects to nothing and phy used by gmac0 is on mdio bus
> of gmac1.
It could be implemented as mfd device. Not sure if it is worth it.
Pro/contra argumentation is welcome.
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2019-05-05 5:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-22 6:40 [PATCH v3 0/3] MIPS: ath79: add ag71xx support Oleksij Rempel
2019-04-22 6:40 ` [PATCH v3 1/3] dt-bindings: net: add qca,ar71xx.txt documentation Oleksij Rempel
2019-04-30 22:51 ` Rob Herring
2019-04-22 6:40 ` [PATCH v3 2/3] MIPS: ath79: ar9331: add Ethernet nodes Oleksij Rempel
2019-04-22 6:40 ` [PATCH v3 3/3] net: ethernet: add ag71xx driver Oleksij Rempel
2019-04-22 13:25 ` Andrew Lunn
2019-05-04 15:40 ` Chuanhong Guo
2019-05-05 5:41 ` Oleksij Rempel [this message]
2019-05-19 7:40 ` Oleksij Rempel
2019-05-04 16:01 ` [PATCH v3 0/3] MIPS: ath79: add ag71xx support Chuanhong Guo
2019-05-04 17:45 ` Oleksij Rempel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190505054119.ac3jxtonkpn4pszn@pengutronix.de \
--to=o.rempel@pengutronix.de \
--cc=andrew@lunn.ch \
--cc=chris.snook@gmail.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=gch981213@gmail.com \
--cc=jcliburn@gmail.com \
--cc=jhogan@kernel.org \
--cc=john@phrozen.org \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=paul.burton@mips.com \
--cc=ralf@linux-mips.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).