Re: [PATCH 1/2] dt-bindings: leds: Add binding for ubnt-spi LED.

[Pavel Machek <pavel@ucw.cz>]

[-- Attachment #1: Type: text/plain, Size: 1910 bytes --]

On Sun 2019-05-05 12:56:35, Jacek Anaszewski wrote:
> Hi,
> 
> On 5/5/19 12:17 AM, Pavel Machek wrote:
> >Hi!
> >
> >>>>I wasn't aware of that list. Maybe "power" or even better "status" would
> >>>>match the function.
> >>>
> >>>Hmm, I've just found out that there are two "wlan-ap" occurrences in
> >>>the existing mainline bindings, so I propose to follow that.
> >
> >Let me see... dove-d3plug.dts has "status", "wlan-ap", "wlan-act".
> >
> >>>>Should I add the color too? So "white:status"?
> >>>
> >>>Yes, why not if it is known. So, having the above I propose:
> >>>
> >>>		label = "white:wlan-ap";
> >>
> >>Linux now runs on many different devices, and I believe userland wants
> >>to know "this is main notification LED for this device" (and the only
> >>one in this case).
> 
> This LED is on the access point, so it should have this affiliation
> somehow represented in the name.
> 
> >...and I guess if you have single LED it will be used for more than
> >"is AP active". IOW it will likely to be more similar to "status" than
> >"wlan-ap".
> 
> IMO if a LED is on some specific device, then it should be reflected
> in the "function" section of the LED name. It facilitates locating in
> physically. If usersapce wants to change its purpose it is free to do
> so. e.g. via triggers. But it will not affect the LED name.

I'd prefer not to do that. Existing ":wlan-ap" LED is a LED probably
indicating that access point is on; while this will normally indicate
system status. Its function is more similar to "status" on
dove-d3plug.dts.

I'd prefer LED names not to depend on function of system they are
in. Status LED on phone should be named same way status LED of
wireless AP is.

Best regards,
								Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]