From: ynezz <ynezz@ibawizard.net>
To: Andy Duan <fugang.duan@nxp.com>
Cc: "Maxime Ripard" <maxime.ripard@bootlin.com>,
"Petr Štetiar" <ynezz@true.cz>,
"davem@davemloft.net" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"john@phrozen.org" <john@phrozen.org>,
"bgolaszewski@baylibre.com" <bgolaszewski@baylibre.com>,
"Srinivas Kandagatla" <srinivas.kandagatla@linaro.org>,
"Andrew Lunn" <andrew@lunn.ch>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Heiner Kallweit" <hkallweit1@gmail.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Frank Rowand" <frowand.list@gmail.com>,
"Mark Rutland" <mark.rutland@arm.com>,
"Alban Bedel" <albeu@free.fr>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH net 0/3] add property "nvmem_macaddr_swap" to swap macaddr bytes order
Date: Mon, 13 May 2019 11:35:39 +0200 [thread overview]
Message-ID: <20190513082625.GA14498@ibawizard.net> (raw)
In-Reply-To: <VI1PR0402MB3600516CFAD9227B0E175DF4FF0F0@VI1PR0402MB3600.eurprd04.prod.outlook.com>
Andy Duan <fugang.duan@nxp.com> [2019-05-13 03:38:32]:
> From: Maxime Ripard <maxime.ripard@bootlin.com> Sent: Friday, May 10, 2019 7:32 PM
> >
> > It looks to me that it should be abstracted away by the nvmem interface and
> > done at the provider level, not the customer.
> >
> If to implement add above features like Petr Štetiar described, it should be abstracted
> In nvmem core driver.
Maxime made it clear, that network layer as a consumer of the nvmem provider
doesn't need to know about this byte order swapping details, so this byte
order swapping should be implemented in nvmem as well, as a bonus it doesn't
matter if you're going to swap 3, 6 or whatever other amount of bytes
described by the reg property, so this functionality could be reused which is
always good.
-- ynezz
next prev parent reply other threads:[~2019-05-13 9:35 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1557476567-17397-4-git-send-email-fugang.duan@nxp.com>
[not found] ` <1557476567-17397-3-git-send-email-fugang.duan@nxp.com>
[not found] ` <1557476567-17397-2-git-send-email-fugang.duan@nxp.com>
[not found] ` <1557476567-17397-1-git-send-email-fugang.duan@nxp.com>
2019-05-10 11:28 ` [PATCH net 0/3] add property "nvmem_macaddr_swap" to swap macaddr bytes order Petr Štetiar
2019-05-10 11:31 ` Maxime Ripard
2019-05-11 14:44 ` NVMEM address DT post processing [Was: Re: [PATCH net 0/3] add property "nvmem_macaddr_swap" to swap macaddr bytes order] Petr Štetiar
2019-05-12 12:19 ` Maxime Ripard
2019-05-13 9:28 ` Petr Štetiar
2019-05-13 8:25 ` Srinivas Kandagatla
2019-05-13 9:07 ` Petr Štetiar
2019-05-13 10:06 ` Srinivas Kandagatla
2019-05-13 11:16 ` Petr Štetiar
2019-05-14 15:13 ` Srinivas Kandagatla
2019-05-14 17:44 ` Petr Štetiar
2019-05-15 17:12 ` Srinivas Kandagatla
2019-05-20 14:28 ` Rob Herring
2019-05-13 3:38 ` [EXT] Re: [PATCH net 0/3] add property "nvmem_macaddr_swap" to swap macaddr bytes order Andy Duan
2019-05-13 9:35 ` ynezz [this message]
2019-05-13 3:06 ` Andy Duan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190513082625.GA14498@ibawizard.net \
--to=ynezz@ibawizard.net \
--cc=albeu@free.fr \
--cc=andrew@lunn.ch \
--cc=bgolaszewski@baylibre.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=frowand.list@gmail.com \
--cc=fugang.duan@nxp.com \
--cc=hkallweit1@gmail.com \
--cc=john@phrozen.org \
--cc=mark.rutland@arm.com \
--cc=maxime.ripard@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=ynezz@true.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).