From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH v3 4/6] dt-bindings: soc/fsl: qe: document new fsl,qe-snums binding Date: Mon, 13 May 2019 12:51:17 -0500 Message-ID: <20190513175117.GA22288@bogus> References: <20190501092841.9026-1-rasmus.villemoes@prevas.dk> <20190513111442.25724-1-rasmus.villemoes@prevas.dk> <20190513111442.25724-5-rasmus.villemoes@prevas.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20190513111442.25724-5-rasmus.villemoes@prevas.dk> Sender: linux-kernel-owner@vger.kernel.org To: Rasmus Villemoes Cc: "devicetree@vger.kernel.org" , Qiang Zhao , Li Yang , "linuxppc-dev@lists.ozlabs.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Scott Wood , Christophe Leroy , Mark Rutland , Joakim Tjernlund , Rasmus Villemoes List-Id: devicetree@vger.kernel.org On Mon, 13 May 2019 11:14:58 +0000, Rasmus Villemoes wrote: > Reading table 4-30, and its footnotes, of the QUICC Engine Block > Reference Manual shows that the set of snum _values_ is not > necessarily just a function of the _number_ of snums, as given in the > fsl,qe-num-snums property. > > As an alternative, to make it easier to add support for other variants > of the QUICC engine IP, this introduces a new binding fsl,qe-snums, > which automatically encodes both the number of snums and the actual > values to use. > > Signed-off-by: Rasmus Villemoes > --- > Rob, thanks for the review of v2. However, since I moved the example > from the commit log to the binding (per Joakim's request), I didn't > add a Reviewed-by tag for this revision. > > .../devicetree/bindings/soc/fsl/cpm_qe/qe.txt | 13 ++++++++++++- > 1 file changed, 12 insertions(+), 1 deletion(-) > Reviewed-by: Rob Herring