devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Manikanta Maddireddy <mmaddireddy@nvidia.com>
To: thierry.reding@gmail.com, bhelgaas@google.com,
	robh+dt@kernel.org, mark.rutland@arm.com, jonathanh@nvidia.com,
	lorenzo.pieralisi@arm.com, vidyas@nvidia.com
Cc: linux-tegra@vger.kernel.org, linux-pci@vger.kernel.org,
	devicetree@vger.kernel.org,
	Manikanta Maddireddy <mmaddireddy@nvidia.com>
Subject: [PATCH V3 13/29] PCI: tegra: Increase the deskew retry time
Date: Mon, 13 May 2019 23:37:28 +0530	[thread overview]
Message-ID: <20190513180744.16493-14-mmaddireddy@nvidia.com> (raw)
In-Reply-To: <20190513180744.16493-1-mmaddireddy@nvidia.com>

Sometimes link speed change from Gen2 to Gen1 fails due to instability
in deskew logic on lane-0 in Tegra210. Increase the deskew retry time
to resolve this issue.

Signed-off-by: Manikanta Maddireddy <mmaddireddy@nvidia.com>
Acked-by: Thierry Reding <treding@nvidia.com>
---
V3: No change

V2: Took care of typos in commit log and coding style comments.

 drivers/pci/controller/pci-tegra.c | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

diff --git a/drivers/pci/controller/pci-tegra.c b/drivers/pci/controller/pci-tegra.c
index 96cd75821872..9c28f1d9f177 100644
--- a/drivers/pci/controller/pci-tegra.c
+++ b/drivers/pci/controller/pci-tegra.c
@@ -209,6 +209,10 @@
 #define  RP_VEND_XP_OPPORTUNISTIC_ACK		(1 << 27)
 #define  RP_VEND_XP_OPPORTUNISTIC_UPDATEFC	(1 << 28)
 
+#define RP_VEND_CTL0	0x00000f44
+#define  RP_VEND_CTL0_DSK_RST_PULSE_WIDTH_MASK	(0xf << 12)
+#define  RP_VEND_CTL0_DSK_RST_PULSE_WIDTH	(0x9 << 12)
+
 #define RP_VEND_CTL1	0x00000f48
 #define  RP_VEND_CTL1_ERPT	(1 << 13)
 
@@ -305,6 +309,7 @@ struct tegra_pcie_soc {
 	bool force_pca_enable;
 	bool program_uphy;
 	bool update_clamp_threshold;
+	bool program_deskew_time;
 	struct {
 		struct {
 			u32 rp_ectl_2_r1;
@@ -620,6 +625,24 @@ static void tegra_pcie_program_ectl_settings(struct tegra_pcie_port *port)
 	writel(value, port->base + RP_ECTL_6_R2);
 }
 
+static void tegra_pcie_apply_sw_fixup(struct tegra_pcie_port *port)
+{
+	const struct tegra_pcie_soc *soc = port->pcie->soc;
+	u32 value;
+
+	/*
+	 * Sometimes link speed change from Gen2 to Gen1 fails due to
+	 * instability in deskew logic on lane-0. Increase the deskew
+	 * retry time to resolve this issue.
+	 */
+	if (soc->program_deskew_time) {
+		value = readl(port->base + RP_VEND_CTL0);
+		value &= ~RP_VEND_CTL0_DSK_RST_PULSE_WIDTH_MASK;
+		value |= RP_VEND_CTL0_DSK_RST_PULSE_WIDTH;
+		writel(value, port->base + RP_VEND_CTL0);
+	}
+}
+
 static void tegra_pcie_port_enable(struct tegra_pcie_port *port)
 {
 	unsigned long ctrl = tegra_pcie_port_get_pex_ctrl(port);
@@ -649,6 +672,8 @@ static void tegra_pcie_port_enable(struct tegra_pcie_port *port)
 
 	if (soc->ectl.enable)
 		tegra_pcie_program_ectl_settings(port);
+
+	tegra_pcie_apply_sw_fixup(port);
 }
 
 static void tegra_pcie_port_disable(struct tegra_pcie_port *port)
@@ -2356,6 +2381,7 @@ static const struct tegra_pcie_soc tegra20_pcie = {
 	.force_pca_enable = false,
 	.program_uphy = true,
 	.update_clamp_threshold = false,
+	.program_deskew_time = false,
 	.ectl.enable = false,
 };
 
@@ -2381,6 +2407,7 @@ static const struct tegra_pcie_soc tegra30_pcie = {
 	.force_pca_enable = false,
 	.program_uphy = true,
 	.update_clamp_threshold = false,
+	.program_deskew_time = false,
 	.ectl.enable = false,
 };
 
@@ -2399,6 +2426,7 @@ static const struct tegra_pcie_soc tegra124_pcie = {
 	.force_pca_enable = false,
 	.program_uphy = true,
 	.update_clamp_threshold = true,
+	.program_deskew_time = false,
 	.ectl.enable = false,
 };
 
@@ -2417,6 +2445,7 @@ static const struct tegra_pcie_soc tegra210_pcie = {
 	.force_pca_enable = true,
 	.program_uphy = true,
 	.update_clamp_threshold = true,
+	.program_deskew_time = true,
 	.ectl = {
 		.regs = {
 			.rp_ectl_2_r1 = 0x0000000f,
@@ -2454,6 +2483,7 @@ static const struct tegra_pcie_soc tegra186_pcie = {
 	.force_pca_enable = false,
 	.program_uphy = false,
 	.update_clamp_threshold = false,
+	.program_deskew_time = false,
 	.ectl.enable = false,
 };
 
-- 
2.17.1

  parent reply	other threads:[~2019-05-13 18:07 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-13 18:07 [PATCH V3 00/29] Enable Tegra PCIe root port features Manikanta Maddireddy
2019-05-13 18:07 ` [PATCH V3 01/29] soc/tegra: pmc: Export tegra_powergate_power_on() Manikanta Maddireddy
2019-05-13 18:07 ` [PATCH V3 02/29] PCI: tegra: Handle failure cases in tegra_pcie_power_on() Manikanta Maddireddy
2019-05-13 18:07 ` [PATCH V3 03/29] PCI: tegra: Rearrange Tegra PCIe driver functions Manikanta Maddireddy
2019-05-13 18:07 ` [PATCH V3 04/29] PCI: tegra: Mask AFI_INTR in runtime suspend Manikanta Maddireddy
2019-05-13 18:07 ` [PATCH V3 05/29] PCI: tegra: Fix PCIe host power up sequence Manikanta Maddireddy
2019-05-13 18:07 ` [PATCH V3 06/29] PCI: tegra: Add PCIe Gen2 link speed support Manikanta Maddireddy
2019-05-13 18:07 ` [PATCH V3 07/29] PCI: tegra: Advertise PCIe Advanced Error Reporting (AER) capability Manikanta Maddireddy
2019-05-13 18:07 ` [PATCH V3 08/29] PCI: tegra: Program UPHY electrical settings for Tegra210 Manikanta Maddireddy
2019-05-13 18:07 ` [PATCH V3 09/29] PCI: tegra: Enable opportunistic UpdateFC and ACK Manikanta Maddireddy
2019-05-13 18:07 ` [PATCH V3 10/29] PCI: tegra: Disable AFI dynamic clock gating Manikanta Maddireddy
2019-05-13 18:07 ` [PATCH V3 11/29] PCI: tegra: Process pending DLL transactions before entering L1 or L2 Manikanta Maddireddy
2019-05-13 18:07 ` [PATCH V3 12/29] PCI: tegra: Enable PCIe xclk clock clamping Manikanta Maddireddy
2019-05-13 18:07 ` Manikanta Maddireddy [this message]
2019-05-13 18:07 ` [PATCH V3 14/29] PCI: tegra: Add SW fixup for RAW violations Manikanta Maddireddy
2019-05-13 18:07 ` [PATCH V3 15/29] PCI: tegra: Update flow control timer frequency in Tegra210 Manikanta Maddireddy
2019-05-13 18:07 ` [PATCH V3 16/29] PCI: tegra: Set target speed as Gen1 before starting LTSSM Manikanta Maddireddy
2019-05-13 18:07 ` [PATCH V3 17/29] PCI: tegra: Fix PLLE power down issue due to CLKREQ# signal Manikanta Maddireddy
2019-05-13 18:07 ` [PATCH V3 18/29] PCI: tegra: Program AFI_CACHE* registers only for Tegra20 Manikanta Maddireddy
2019-05-13 18:07 ` [PATCH V3 19/29] PCI: tegra: Change PRSNT_SENSE IRQ log to debug Manikanta Maddireddy
2019-05-13 18:07 ` [PATCH V3 20/29] PCI: tegra: Use legacy IRQ for port service drivers Manikanta Maddireddy
2019-05-13 18:07 ` [PATCH V3 21/29] PCI: tegra: Add AFI_PEX2_CTRL reg offset as part of soc struct Manikanta Maddireddy
2019-05-13 18:07 ` [PATCH V3 22/29] PCI: tegra: Access endpoint config only if PCIe link is up Manikanta Maddireddy
2019-05-13 18:07 ` [PATCH V3 23/29] dt-bindings: pci: tegra: Document PCIe DPD pinctrl optional prop Manikanta Maddireddy
2019-05-13 18:07 ` [PATCH V3 24/29] arm64: tegra: Add PEX DPD states as pinctrl properties Manikanta Maddireddy
2019-05-13 18:07 ` [PATCH V3 25/29] PCI: tegra: Put PEX CLK & BIAS pads in DPD mode Manikanta Maddireddy
2019-05-13 18:07 ` [PATCH V3 26/29] PCI: Add DT binding for "reset-gpios" property Manikanta Maddireddy
2019-05-14 18:23   ` Rob Herring
2019-05-13 18:07 ` [PATCH V3 27/29] PCI: OF: Add of_pci_get_reset_gpio() to parse reset-gpios from DT Manikanta Maddireddy
2019-05-14 18:31   ` Rob Herring
2019-05-16  5:50     ` Manikanta Maddireddy
2019-05-13 18:07 ` [PATCH V3 28/29] PCI: tegra: Add support for GPIO based PERST# Manikanta Maddireddy
2019-05-13 18:07 ` [PATCH V3 29/29] PCI: tegra: Change link retry log level to debug Manikanta Maddireddy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190513180744.16493-14-mmaddireddy@nvidia.com \
    --to=mmaddireddy@nvidia.com \
    --cc=bhelgaas@google.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jonathanh@nvidia.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=thierry.reding@gmail.com \
    --cc=vidyas@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).