* [PATCH 1/3] dt-bindings: mfd: lp87565: Add lp87561 configuration
2019-05-15 10:08 [PATCH 0/3] mfd: lp87565: Add support for 4-phase lp87561 combination Keerthy
@ 2019-05-15 10:08 ` Keerthy
2019-06-03 9:03 ` Lee Jones
2019-05-15 10:08 ` [PATCH 2/3] mfd: lp87565: Add support for 4-phase lp87561 combination Keerthy
2019-05-15 10:08 ` [PATCH 3/3] regulator: lp87565: Add 4-phase lp87561 regulator support Keerthy
2 siblings, 1 reply; 8+ messages in thread
From: Keerthy @ 2019-05-15 10:08 UTC (permalink / raw)
To: lee.jones, robh+dt, broonie
Cc: linux-kernel, devicetree, linux-omap, t-kristo, j-keerthy
lp87561 is a single output 4-phase regulator configuration.
Add support for the same.
Data Sheet: https://www.ti.com/lit/ds/symlink/lp87561-q1.pdf
Signed-off-by: Keerthy <j-keerthy@ti.com>
---
.../devicetree/bindings/mfd/lp87565.txt | 36 +++++++++++++++++++
1 file changed, 36 insertions(+)
diff --git a/Documentation/devicetree/bindings/mfd/lp87565.txt b/Documentation/devicetree/bindings/mfd/lp87565.txt
index a48df7c08ab0..41671e0dc26b 100644
--- a/Documentation/devicetree/bindings/mfd/lp87565.txt
+++ b/Documentation/devicetree/bindings/mfd/lp87565.txt
@@ -41,3 +41,39 @@ lp87565_pmic: pmic@60 {
};
};
};
+
+TI LP87561 PMIC:
+
+This is a single output 4-phase regulator configuration
+
+Required properties:
+ - compatible: "ti,lp87561-q1"
+ - reg: I2C slave address.
+ - gpio-controller: Marks the device node as a GPIO Controller.
+ - #gpio-cells: Should be two. The first cell is the pin number and
+ the second cell is used to specify flags.
+ See ../gpio/gpio.txt for more information.
+ - xxx-in-supply: Phandle to parent supply node of each regulator
+ populated under regulators node. xxx should match
+ the supply_name populated in driver.
+Example:
+
+lp87561_pmic: pmic@62 {
+ compatible = "ti,lp87561-q1";
+ reg = <0x62>;
+ gpio-controller;
+ #gpio-cells = <2>;
+
+ buck3210-in-supply = <&vsys_3v3>;
+
+ regulators: regulators {
+ buck3210_reg: buck3210 {
+ /* VDD_CORE */
+ regulator-name = "buck3210";
+ regulator-min-microvolt = <800000>;
+ regulator-max-microvolt = <800000>;
+ regulator-always-on;
+ regulator-boot-on;
+ };
+ };
+};
--
2.17.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH 1/3] dt-bindings: mfd: lp87565: Add lp87561 configuration
2019-05-15 10:08 ` [PATCH 1/3] dt-bindings: mfd: lp87565: Add lp87561 configuration Keerthy
@ 2019-06-03 9:03 ` Lee Jones
0 siblings, 0 replies; 8+ messages in thread
From: Lee Jones @ 2019-06-03 9:03 UTC (permalink / raw)
To: Keerthy; +Cc: robh+dt, broonie, linux-kernel, devicetree, linux-omap, t-kristo
On Wed, 15 May 2019, Keerthy wrote:
> lp87561 is a single output 4-phase regulator configuration.
> Add support for the same.
>
> Data Sheet: https://www.ti.com/lit/ds/symlink/lp87561-q1.pdf
>
> Signed-off-by: Keerthy <j-keerthy@ti.com>
> ---
> .../devicetree/bindings/mfd/lp87565.txt | 36 +++++++++++++++++++
> 1 file changed, 36 insertions(+)
Applied, thanks.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 2/3] mfd: lp87565: Add support for 4-phase lp87561 combination
2019-05-15 10:08 [PATCH 0/3] mfd: lp87565: Add support for 4-phase lp87561 combination Keerthy
2019-05-15 10:08 ` [PATCH 1/3] dt-bindings: mfd: lp87565: Add lp87561 configuration Keerthy
@ 2019-05-15 10:08 ` Keerthy
2019-06-03 9:03 ` Lee Jones
2019-05-15 10:08 ` [PATCH 3/3] regulator: lp87565: Add 4-phase lp87561 regulator support Keerthy
2 siblings, 1 reply; 8+ messages in thread
From: Keerthy @ 2019-05-15 10:08 UTC (permalink / raw)
To: lee.jones, robh+dt, broonie
Cc: linux-kernel, devicetree, linux-omap, t-kristo, j-keerthy
Add support for 4-phase lp87561 combination.
Data Sheet: https://www.ti.com/lit/ds/symlink/lp87561-q1.pdf
Signed-off-by: Keerthy <j-keerthy@ti.com>
---
drivers/mfd/lp87565.c | 4 ++++
include/linux/mfd/lp87565.h | 2 ++
2 files changed, 6 insertions(+)
diff --git a/drivers/mfd/lp87565.c b/drivers/mfd/lp87565.c
index 32d2a07d4354..8ad688fe75f9 100644
--- a/drivers/mfd/lp87565.c
+++ b/drivers/mfd/lp87565.c
@@ -33,6 +33,10 @@ static const struct of_device_id of_lp87565_match_table[] = {
.compatible = "ti,lp87565-q1",
.data = (void *)LP87565_DEVICE_TYPE_LP87565_Q1,
},
+ {
+ .compatible = "ti,lp87561-q1",
+ .data = (void *)LP87565_DEVICE_TYPE_LP87561_Q1,
+ },
{}
};
MODULE_DEVICE_TABLE(of, of_lp87565_match_table);
diff --git a/include/linux/mfd/lp87565.h b/include/linux/mfd/lp87565.h
index d0c91ba65525..976447607ea2 100644
--- a/include/linux/mfd/lp87565.h
+++ b/include/linux/mfd/lp87565.h
@@ -17,6 +17,7 @@
enum lp87565_device_type {
LP87565_DEVICE_TYPE_UNKNOWN = 0,
+ LP87565_DEVICE_TYPE_LP87561_Q1,
LP87565_DEVICE_TYPE_LP87565_Q1,
};
@@ -249,6 +250,7 @@ enum LP87565_regulator_id {
LP87565_BUCK_3,
LP87565_BUCK_10,
LP87565_BUCK_23,
+ LP87565_BUCK_3210,
};
/**
--
2.17.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH 2/3] mfd: lp87565: Add support for 4-phase lp87561 combination
2019-05-15 10:08 ` [PATCH 2/3] mfd: lp87565: Add support for 4-phase lp87561 combination Keerthy
@ 2019-06-03 9:03 ` Lee Jones
0 siblings, 0 replies; 8+ messages in thread
From: Lee Jones @ 2019-06-03 9:03 UTC (permalink / raw)
To: Keerthy; +Cc: robh+dt, broonie, linux-kernel, devicetree, linux-omap, t-kristo
On Wed, 15 May 2019, Keerthy wrote:
> Add support for 4-phase lp87561 combination.
>
> Data Sheet: https://www.ti.com/lit/ds/symlink/lp87561-q1.pdf
>
> Signed-off-by: Keerthy <j-keerthy@ti.com>
> ---
> drivers/mfd/lp87565.c | 4 ++++
> include/linux/mfd/lp87565.h | 2 ++
> 2 files changed, 6 insertions(+)
Applied, thanks.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 3/3] regulator: lp87565: Add 4-phase lp87561 regulator support
2019-05-15 10:08 [PATCH 0/3] mfd: lp87565: Add support for 4-phase lp87561 combination Keerthy
2019-05-15 10:08 ` [PATCH 1/3] dt-bindings: mfd: lp87565: Add lp87561 configuration Keerthy
2019-05-15 10:08 ` [PATCH 2/3] mfd: lp87565: Add support for 4-phase lp87561 combination Keerthy
@ 2019-05-15 10:08 ` Keerthy
2019-05-15 11:08 ` Mark Brown
2 siblings, 1 reply; 8+ messages in thread
From: Keerthy @ 2019-05-15 10:08 UTC (permalink / raw)
To: lee.jones, robh+dt, broonie
Cc: linux-kernel, devicetree, linux-omap, t-kristo, j-keerthy
The LP8756x family has a single output 4-phase regulator
configuration. Add support for the same. The control
lies in the master buck which is buck0 for 4-phase
configuration. Enable/disable/voltage set happen via
buck0 registers.
Data Sheet: https://www.ti.com/lit/ds/symlink/lp87561-q1.pdf
Signed-off-by: Keerthy <j-keerthy@ti.com>
---
drivers/regulator/lp87565-regulator.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/drivers/regulator/lp87565-regulator.c b/drivers/regulator/lp87565-regulator.c
index 81eb4b890c0c..8255650df1cd 100644
--- a/drivers/regulator/lp87565-regulator.c
+++ b/drivers/regulator/lp87565-regulator.c
@@ -153,6 +153,12 @@ static const struct lp87565_regulator regulators[] = {
LP87565_REG_BUCK2_CTRL_1,
LP87565_BUCK_CTRL_1_EN, 3230,
buck0_1_2_3_ranges, LP87565_REG_BUCK2_CTRL_2),
+ LP87565_REGULATOR("BUCK3210", LP87565_BUCK_3210, "buck3210",
+ lp87565_buck_ops, 256, LP87565_REG_BUCK0_VOUT,
+ LP87565_BUCK_VSET, LP87565_REG_BUCK0_CTRL_1,
+ LP87565_BUCK_CTRL_1_EN |
+ LP87565_BUCK_CTRL_1_FPWM_MP_0_2, 3230,
+ buck0_1_2_3_ranges, LP87565_REG_BUCK0_CTRL_2),
};
static int lp87565_regulator_probe(struct platform_device *pdev)
@@ -172,6 +178,9 @@ static int lp87565_regulator_probe(struct platform_device *pdev)
if (lp87565->dev_type == LP87565_DEVICE_TYPE_LP87565_Q1) {
min_idx = LP87565_BUCK_10;
max_idx = LP87565_BUCK_23;
+ } else if (lp87565->dev_type == LP87565_DEVICE_TYPE_LP87561_Q1) {
+ min_idx = LP87565_BUCK_3210;
+ max_idx = LP87565_BUCK_3210;
}
for (i = min_idx; i <= max_idx; i++) {
--
2.17.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH 3/3] regulator: lp87565: Add 4-phase lp87561 regulator support
2019-05-15 10:08 ` [PATCH 3/3] regulator: lp87565: Add 4-phase lp87561 regulator support Keerthy
@ 2019-05-15 11:08 ` Mark Brown
2019-05-15 11:13 ` Keerthy
0 siblings, 1 reply; 8+ messages in thread
From: Mark Brown @ 2019-05-15 11:08 UTC (permalink / raw)
To: Keerthy; +Cc: lee.jones, robh+dt, linux-kernel, devicetree, linux-omap,
t-kristo
[-- Attachment #1: Type: text/plain, Size: 460 bytes --]
On Wed, May 15, 2019 at 03:38:48PM +0530, Keerthy wrote:
> @@ -172,6 +178,9 @@ static int lp87565_regulator_probe(struct platform_device *pdev)
> if (lp87565->dev_type == LP87565_DEVICE_TYPE_LP87565_Q1) {
> min_idx = LP87565_BUCK_10;
> max_idx = LP87565_BUCK_23;
> + } else if (lp87565->dev_type == LP87565_DEVICE_TYPE_LP87561_Q1) {
> + min_idx = LP87565_BUCK_3210;
> + max_idx = LP87565_BUCK_3210;
This if/else chain should be a switch statement.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH 3/3] regulator: lp87565: Add 4-phase lp87561 regulator support
2019-05-15 11:08 ` Mark Brown
@ 2019-05-15 11:13 ` Keerthy
0 siblings, 0 replies; 8+ messages in thread
From: Keerthy @ 2019-05-15 11:13 UTC (permalink / raw)
To: Mark Brown
Cc: lee.jones, robh+dt, linux-kernel, devicetree, linux-omap,
t-kristo
On 15/05/19 4:38 PM, Mark Brown wrote:
> On Wed, May 15, 2019 at 03:38:48PM +0530, Keerthy wrote:
>
>> @@ -172,6 +178,9 @@ static int lp87565_regulator_probe(struct platform_device *pdev)
>> if (lp87565->dev_type == LP87565_DEVICE_TYPE_LP87565_Q1) {
>> min_idx = LP87565_BUCK_10;
>> max_idx = LP87565_BUCK_23;
>> + } else if (lp87565->dev_type == LP87565_DEVICE_TYPE_LP87561_Q1) {
>> + min_idx = LP87565_BUCK_3210;
>> + max_idx = LP87565_BUCK_3210;
>
> This if/else chain should be a switch statement.
Okay. I will convert that in v2.
Thanks,
Keerthy
>
^ permalink raw reply [flat|nested] 8+ messages in thread