From: Mark Brown <broonie@kernel.org>
To: Keerthy <j-keerthy@ti.com>
Cc: lee.jones@linaro.org, robh+dt@kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-omap@vger.kernel.org, t-kristo@ti.com
Subject: Re: [PATCH 3/3] regulator: lp87565: Add 4-phase lp87561 regulator support
Date: Wed, 15 May 2019 12:08:51 +0100 [thread overview]
Message-ID: <20190515110851.GD5613@sirena.org.uk> (raw)
In-Reply-To: <20190515100848.19560-4-j-keerthy@ti.com>
[-- Attachment #1: Type: text/plain, Size: 460 bytes --]
On Wed, May 15, 2019 at 03:38:48PM +0530, Keerthy wrote:
> @@ -172,6 +178,9 @@ static int lp87565_regulator_probe(struct platform_device *pdev)
> if (lp87565->dev_type == LP87565_DEVICE_TYPE_LP87565_Q1) {
> min_idx = LP87565_BUCK_10;
> max_idx = LP87565_BUCK_23;
> + } else if (lp87565->dev_type == LP87565_DEVICE_TYPE_LP87561_Q1) {
> + min_idx = LP87565_BUCK_3210;
> + max_idx = LP87565_BUCK_3210;
This if/else chain should be a switch statement.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-05-15 11:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-15 10:08 [PATCH 0/3] mfd: lp87565: Add support for 4-phase lp87561 combination Keerthy
2019-05-15 10:08 ` [PATCH 1/3] dt-bindings: mfd: lp87565: Add lp87561 configuration Keerthy
2019-06-03 9:03 ` Lee Jones
2019-05-15 10:08 ` [PATCH 2/3] mfd: lp87565: Add support for 4-phase lp87561 combination Keerthy
2019-06-03 9:03 ` Lee Jones
2019-05-15 10:08 ` [PATCH 3/3] regulator: lp87565: Add 4-phase lp87561 regulator support Keerthy
2019-05-15 11:08 ` Mark Brown [this message]
2019-05-15 11:13 ` Keerthy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190515110851.GD5613@sirena.org.uk \
--to=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=j-keerthy@ti.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).