From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shawn Guo Subject: Re: [PATCH] arm64: dts: ls1028a: Fix CPU idle fail. Date: Fri, 17 May 2019 09:32:53 +0800 Message-ID: <20190517013252.GV15856@dragon> References: <20190507074454.41589-1-ran.wang_1@nxp.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20190507074454.41589-1-ran.wang_1@nxp.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Ran Wang Cc: Mark Rutland , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Leo Li , Rob Herring , "linux-arm-kernel@lists.infradead.org" List-Id: devicetree@vger.kernel.org On Tue, May 07, 2019 at 07:43:37AM +0000, Ran Wang wrote: > PSCI spec define 1st parameter's bit 16 of function CPU_SUSPEND to > indicate CPU State Type: 0 for standby, 1 for power down. In this > case, we want to select standby for CPU idle feature. But current > setting wrongly select power down and cause CPU SUSPEND fail every > time. Need this fix. > > Signed-off-by: Ran Wang Do we need a Fixes tag for this? Shawn > --- > arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 18 +++++++++--------- > 1 files changed, 9 insertions(+), 9 deletions(-) > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > index b045812..bf7f845 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > @@ -28,7 +28,7 @@ > enable-method = "psci"; > clocks = <&clockgen 1 0>; > next-level-cache = <&l2>; > - cpu-idle-states = <&CPU_PH20>; > + cpu-idle-states = <&CPU_PW20>; > }; > > cpu1: cpu@1 { > @@ -38,7 +38,7 @@ > enable-method = "psci"; > clocks = <&clockgen 1 0>; > next-level-cache = <&l2>; > - cpu-idle-states = <&CPU_PH20>; > + cpu-idle-states = <&CPU_PW20>; > }; > > l2: l2-cache { > @@ -53,13 +53,13 @@ > */ > entry-method = "arm,psci"; > > - CPU_PH20: cpu-ph20 { > - compatible = "arm,idle-state"; > - idle-state-name = "PH20"; > - arm,psci-suspend-param = <0x00010000>; > - entry-latency-us = <1000>; > - exit-latency-us = <1000>; > - min-residency-us = <3000>; > + CPU_PW20: cpu-pw20 { > + compatible = "arm,idle-state"; > + idle-state-name = "PW20"; > + arm,psci-suspend-param = <0x0>; > + entry-latency-us = <2000>; > + exit-latency-us = <2000>; > + min-residency-us = <6000>; > }; > }; > > -- > 1.7.1 >