From: Pavel Machek <pavel@ucw.cz>
To: oss@c-mauderer.de
Cc: linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Dan Murphy <dmurphy@ti.com>, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>
Subject: Re: [PATCH v4 1/2] dt-bindings: leds: Add binding for spi-byte LED.
Date: Sun, 19 May 2019 23:25:01 +0200 [thread overview]
Message-ID: <20190519212501.GC31403@amd> (raw)
In-Reply-To: <20190513193307.11591-1-oss@c-mauderer.de>
[-- Attachment #1: Type: text/plain, Size: 1275 bytes --]
Hi!
> From: Christian Mauderer <oss@c-mauderer.de>
>
> This patch adds the binding documentation for a simple SPI based LED
> controller which use only one byte for setting the brightness.
>
> Signed-off-by: Christian Mauderer <oss@c-mauderer.de>
> ---
> diff --git a/Documentation/devicetree/bindings/leds/leds-spi-byte.txt b/Documentation/devicetree/bindings/leds/leds-spi-byte.txt
> new file mode 100644
> index 000000000000..28b6b2d9091e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/leds/leds-spi-byte.txt
> @@ -0,0 +1,44 @@
> +* Single Byte SPI LED Device Driver.
> +The driver can be used for controllers with a very simple SPI protocol:
> +- one LED is controlled by a single byte on MOSI
> +- the value of the byte gives the brightness between two values (lowest to
> + highest)
> +- no return value is necessary (no MISO signal)
I'd expect this file to be named acb-spi-led.txt, or something, and
talk about that u-controller, not its device driver -- as devicetree
binding describes hardware, not driver.
But you already have an ack from rob, so...
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2019-05-19 21:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-13 19:33 [PATCH v4 1/2] dt-bindings: leds: Add binding for spi-byte LED oss
2019-05-13 19:33 ` [PATCH v4 2/2] leds: spi-byte: add single byte SPI LED driver oss
2019-05-19 21:32 ` Pavel Machek
2019-05-14 18:19 ` [PATCH v4 1/2] dt-bindings: leds: Add binding for spi-byte LED Rob Herring
2019-05-19 21:25 ` Pavel Machek [this message]
2019-05-20 17:19 ` Christian Mauderer
2019-05-20 20:15 ` Jacek Anaszewski
2019-05-20 20:22 ` Christian Mauderer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190519212501.GC31403@amd \
--to=pavel@ucw.cz \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-leds@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=oss@c-mauderer.de \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).