Re: [PATCH v3 1/4] dt-bindings: watchdog: add Allwinner H6 watchdog

Maxime Ripard
2019-05-20T07:35:29Z

[-- Attachment #1: Type: text/plain, Size: 1405 bytes --]

On Sat, May 18, 2019 at 05:23:52PM +0200, Clément Péron wrote:
> Allwinner H6 has a similar watchdog as the A64 which is already
> a compatible of the A31.
>
> This commit sort the lines and add the H6 compatible.
>
> Signed-off-by: Clément Péron <peron.clem@gmail.com>
> ---
> .../devicetree/bindings/watchdog/sunxi-wdt.txt | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/watchdog/sunxi-wdt.txt b/Documentation/devicetree/bindings/watchdog/sunxi-wdt.txt
> index 46055254e8dd..f4810f8ad1c5 100644
> --- a/Documentation/devicetree/bindings/watchdog/sunxi-wdt.txt
> +++ b/Documentation/devicetree/bindings/watchdog/sunxi-wdt.txt
> @@ -3,10 +3,12 @@ Allwinner SoCs Watchdog timer
> Required properties:
>
> - compatible : should be one of
> - "allwinner,sun4i-a10-wdt"
> - "allwinner,sun6i-a31-wdt"
> - "allwinner,sun50i-a64-wdt","allwinner,sun6i-a31-wdt"
> - "allwinner,suniv-f1c100s-wdt", "allwinner,sun4i-a10-wdt"

That sorting was kind of intentional

> + - "allwinner,sun4i-a10-wdt"
> + - "allwinner,sun50i-a64-wdt","allwinner,sun6i-a31-wdt"
> + - "allwinner,sun50i-h6-wdt","allwinner,sun50i-a64-wdt",
> + "allwinner,sun6i-a31-wdt"

Is there a reason to keep the A64 compatible?

Thanks,
Maxime

--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]