Re: [PATCH v3 1/4] dt-bindings: watchdog: add Allwinner H6 watchdog

Maxime Ripard
2019-05-20T14:42:58Z

[-- Attachment #1: Type: text/plain, Size: 985 bytes --]

On Mon, May 20, 2019 at 10:14:10AM +0200, Clément Péron wrote:
> >
> > > + - "allwinner,sun4i-a10-wdt"
> > > + - "allwinner,sun50i-a64-wdt","allwinner,sun6i-a31-wdt"
> > > + - "allwinner,sun50i-h6-wdt","allwinner,sun50i-a64-wdt",
> > > + "allwinner,sun6i-a31-wdt"
> >
> > Is there a reason to keep the A64 compatible?
>
> Yes, A64 and H6 has the exact same memory mapping looking at the datasheet.
> So if there is an errata or a new feature for the A64, it should be
> also compatible with the H6.
> Which is not the case with A31 (WDT_KEY_FIELD is not preset)

The thing is, if you use those three compatibles, then you're saying
that it's ok for the OS to use first the H6 driver, then the A64
driver, and then the A31 driver.

If the A31 isn't compatible, then it shouldn't be listed there. And if
it is, then you can skip the A64 compatible.

Maxime

--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]