From: Andrew Lunn <andrew@lunn.ch>
To: Sagar Shrikant Kadam <sagar.kadam@sifive.com>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
peter@korsgaard.com, palmer@sifive.com,
linux-kernel@vger.kernel.org, robh+dt@kernel.org,
linux-i2c@vger.kernel.org, paul.walmsley@sifive.com,
linux-riscv@lists.infradead.org
Subject: Re: [PATCH v4 3/3] i2c-ocores: sifive: add polling mode workaround for FU540-C000 SoC
Date: Mon, 20 May 2019 14:41:07 +0200 [thread overview]
Message-ID: <20190520124107.GA25785@lunn.ch> (raw)
In-Reply-To: <1558354817-12034-4-git-send-email-sagar.kadam@sifive.com>
> @@ -406,7 +416,7 @@ static int ocores_xfer(struct i2c_adapter *adap,
> {
> struct ocores_i2c *i2c = i2c_get_adapdata(adap);
>
> - if (i2c->flags & OCORES_FLAG_POLL)
> + if ((i2c->flags & (OCORES_FLAG_POLL | OCORES_FLAG_BROKEN_IRQ)))
> return ocores_xfer_polling(adap, msgs, num);
> return ocores_xfer_core(i2c, msgs, num, false);
> }
You are not listening to what i said. All you need to know here is
that you must poll. It does not matter if the IRQ is broken or not.
> irq = platform_get_irq(pdev, 0);
> if (irq == -ENXIO) {
> - i2c->flags |= OCORES_FLAG_POLL;
If there is no interrupt, you need to poll. So keep this line.
> + /*
> + * Set a OCORES_FLAG_BROKEN_IRQ to enable workaround for
> + * FU540-C000 SoC in polling mode interface of i2c-ocore driver.
> + * Else enable default polling mode interface for SIFIVE/OCORE
> + * device types.
> + */
> + match = of_match_node(ocores_i2c_match, pdev->dev.of_node);
> + if (match && (long)match->data == TYPE_SIFIVE_REV0)
> + i2c->flags |= OCORES_FLAG_BROKEN_IRQ;
If it is a OCORE, IRQ is broken, so OR in OCORES_FLAG_BROKEN_IRQ.
>
> - if (!(i2c->flags & OCORES_FLAG_POLL)) {
> + if (!(i2c->flags & (OCORES_FLAG_POLL | OCORES_FLAG_BROKEN_IRQ))) {
> ret = devm_request_irq(&pdev->dev, irq, ocores_isr, 0,
> pdev->name, i2c);
Here you just need to know if you are polling. Broken IRQ does not
matter.
Andrew
next prev parent reply other threads:[~2019-05-20 12:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-20 12:20 [PATCH v4 0/3] Extend dt bindings to support I2C on sifive devices and a fix broken IRQ in polling mode Sagar Shrikant Kadam
2019-05-20 12:20 ` [PATCH v4 1/3] dt-bindings: i2c: extend existing opencore bindings Sagar Shrikant Kadam
2019-05-20 12:20 ` [PATCH v4 2/3] i2c-ocores: sifive: add support for i2c device on FU540-c000 SoC Sagar Shrikant Kadam
2019-05-20 12:20 ` [PATCH v4 3/3] i2c-ocores: sifive: add polling mode workaround for FU540-C000 SoC Sagar Shrikant Kadam
2019-05-20 12:41 ` Andrew Lunn [this message]
2019-05-20 13:27 ` Sagar Kadam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190520124107.GA25785@lunn.ch \
--to=andrew@lunn.ch \
--cc=devicetree@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=palmer@sifive.com \
--cc=paul.walmsley@sifive.com \
--cc=peter@korsgaard.com \
--cc=robh+dt@kernel.org \
--cc=sagar.kadam@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).