Re: [PATCH] dt-bindings: Convert vendor prefixes to json-schema

[Maxime Ripard <maxime.ripard@bootlin.com>]

[-- Attachment #1: Type: text/plain, Size: 1042 bytes --]

Hi Rob,

On Fri, May 10, 2019 at 02:40:18PM -0500, Rob Herring wrote:
> Convert the vendor prefix registry to a schema. This will enable checking
> that new vendor prefixes are added (in addition to the less than perfect
> checkpatch.pl check) and will also check against adding other prefixes
> which are not vendors.
>
> Converted vendor-prefixes.txt using the following sed script:
>
> sed -e 's/\([a-zA-Z0-9\-]*\)[[:space:]]*\([a-zA-Z0-9].*\)/  "^\1,\.\*\":\n    description: \2/'
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> As vendor prefix updates come in via multiple trees, I plan to merge
> this before -rc1 to avoid cross tree conflicts.

I just tried this with the 5.2-rc1 release, and this very
significantly slows down the validation.

With a dtbs_check run on (arm's) sunxi_defconfig, on my core-i5 with 4
threads, I go from 1.30 minutes to more than 12.

Should we improve the dt-validate tool before merging this patch?

Maxime

--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]