* [PATCH v2 1/2] dt-bindings: mtd: brcmnand: Make nand-ecc-strength and nand-ecc-step-size optional
@ 2019-05-20 19:05 Kamal Dasu
2019-05-21 8:53 ` Miquel Raynal
2019-05-21 9:31 ` Schrempf Frieder
0 siblings, 2 replies; 4+ messages in thread
From: Kamal Dasu @ 2019-05-20 19:05 UTC (permalink / raw)
To: linux-mtd
Cc: bcm-kernel-feedback-list, linux-kernel, Kamal Dasu,
David Woodhouse, Brian Norris, Marek Vasut, Miquel Raynal,
Richard Weinberger, Vignesh Raghavendra, Rob Herring,
Mark Rutland, devicetree
nand-ecc-strength and nand-ecc-step-size can be made optional as
brcmnand driver can support using raw NAND layer detected values.
Signed-off-by: Kamal Dasu <kdasu.kdev@gmail.com>
---
Documentation/devicetree/bindings/mtd/brcm,brcmnand.txt | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/mtd/brcm,brcmnand.txt b/Documentation/devicetree/bindings/mtd/brcm,brcmnand.txt
index bcda1df..29feaba 100644
--- a/Documentation/devicetree/bindings/mtd/brcm,brcmnand.txt
+++ b/Documentation/devicetree/bindings/mtd/brcm,brcmnand.txt
@@ -101,10 +101,10 @@ Required properties:
number (e.g., 0, 1, 2, etc.)
- #address-cells : see partition.txt
- #size-cells : see partition.txt
-- nand-ecc-strength : see nand.txt
-- nand-ecc-step-size : must be 512 or 1024. See nand.txt
Optional properties:
+- nand-ecc-strength : see nand.txt
+- nand-ecc-step-size : must be 512 or 1024. See nand.txt
- nand-on-flash-bbt : boolean, to enable the on-flash BBT for this
chip-select. See nand.txt
- brcm,nand-oob-sector-size : integer, to denote the spare area sector size
--
1.9.0.138.g2de3478
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v2 1/2] dt-bindings: mtd: brcmnand: Make nand-ecc-strength and nand-ecc-step-size optional
2019-05-20 19:05 [PATCH v2 1/2] dt-bindings: mtd: brcmnand: Make nand-ecc-strength and nand-ecc-step-size optional Kamal Dasu
@ 2019-05-21 8:53 ` Miquel Raynal
2019-05-21 9:31 ` Schrempf Frieder
1 sibling, 0 replies; 4+ messages in thread
From: Miquel Raynal @ 2019-05-21 8:53 UTC (permalink / raw)
To: Kamal Dasu
Cc: linux-mtd, bcm-kernel-feedback-list, linux-kernel,
David Woodhouse, Brian Norris, Marek Vasut, Richard Weinberger,
Vignesh Raghavendra, Rob Herring, Mark Rutland, devicetree
Hi Kamal,
Kamal Dasu <kdasu.kdev@gmail.com> wrote on Mon, 20 May 2019 15:05:11
-0400:
> nand-ecc-strength and nand-ecc-step-size can be made optional as
> brcmnand driver can support using raw NAND layer detected values.
>
> Signed-off-by: Kamal Dasu <kdasu.kdev@gmail.com>
> ---
> Documentation/devicetree/bindings/mtd/brcm,brcmnand.txt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mtd/brcm,brcmnand.txt b/Documentation/devicetree/bindings/mtd/brcm,brcmnand.txt
> index bcda1df..29feaba 100644
> --- a/Documentation/devicetree/bindings/mtd/brcm,brcmnand.txt
> +++ b/Documentation/devicetree/bindings/mtd/brcm,brcmnand.txt
> @@ -101,10 +101,10 @@ Required properties:
> number (e.g., 0, 1, 2, etc.)
> - #address-cells : see partition.txt
> - #size-cells : see partition.txt
> -- nand-ecc-strength : see nand.txt
> -- nand-ecc-step-size : must be 512 or 1024. See nand.txt
>
> Optional properties:
> +- nand-ecc-strength : see nand.txt
> +- nand-ecc-step-size : must be 512 or 1024. See nand.txt
> - nand-on-flash-bbt : boolean, to enable the on-flash BBT for this
> chip-select. See nand.txt
> - brcm,nand-oob-sector-size : integer, to denote the spare area sector size
Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
Thanks,
Miquèl
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: mtd: brcmnand: Make nand-ecc-strength and nand-ecc-step-size optional
2019-05-20 19:05 [PATCH v2 1/2] dt-bindings: mtd: brcmnand: Make nand-ecc-strength and nand-ecc-step-size optional Kamal Dasu
2019-05-21 8:53 ` Miquel Raynal
@ 2019-05-21 9:31 ` Schrempf Frieder
2019-05-21 9:32 ` Miquel Raynal
1 sibling, 1 reply; 4+ messages in thread
From: Schrempf Frieder @ 2019-05-21 9:31 UTC (permalink / raw)
To: Kamal Dasu, linux-mtd@lists.infradead.org
Cc: Mark Rutland, devicetree@vger.kernel.org, Vignesh Raghavendra,
Richard Weinberger, linux-kernel@vger.kernel.org, Marek Vasut,
Rob Herring, bcm-kernel-feedback-list@broadcom.com, Miquel Raynal,
Brian Norris, David Woodhouse
Hi Kamal,
On 20.05.19 21:05, Kamal Dasu wrote:
> nand-ecc-strength and nand-ecc-step-size can be made optional as
> brcmnand driver can support using raw NAND layer detected values.
>
> Signed-off-by: Kamal Dasu <kdasu.kdev@gmail.com>
> ---
> Documentation/devicetree/bindings/mtd/brcm,brcmnand.txt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mtd/brcm,brcmnand.txt b/Documentation/devicetree/bindings/mtd/brcm,brcmnand.txt
> index bcda1df..29feaba 100644
> --- a/Documentation/devicetree/bindings/mtd/brcm,brcmnand.txt
> +++ b/Documentation/devicetree/bindings/mtd/brcm,brcmnand.txt
> @@ -101,10 +101,10 @@ Required properties:
> number (e.g., 0, 1, 2, etc.)
> - #address-cells : see partition.txt
> - #size-cells : see partition.txt
> -- nand-ecc-strength : see nand.txt
> -- nand-ecc-step-size : must be 512 or 1024. See nand.txt
>
> Optional properties:
> +- nand-ecc-strength : see nand.txt
> +- nand-ecc-step-size : must be 512 or 1024. See nand.txt
> - nand-on-flash-bbt : boolean, to enable the on-flash BBT for this
> chip-select. See nand.txt
> - brcm,nand-oob-sector-size : integer, to denote the spare area sector size
I think you also need to change all references to nand.txt. This file
was recently moved to nand-controller.yaml.
Regards,
Frieder
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: mtd: brcmnand: Make nand-ecc-strength and nand-ecc-step-size optional
2019-05-21 9:31 ` Schrempf Frieder
@ 2019-05-21 9:32 ` Miquel Raynal
0 siblings, 0 replies; 4+ messages in thread
From: Miquel Raynal @ 2019-05-21 9:32 UTC (permalink / raw)
To: Schrempf Frieder
Cc: Kamal Dasu, linux-mtd@lists.infradead.org, Mark Rutland,
devicetree@vger.kernel.org, Vignesh Raghavendra,
Richard Weinberger, linux-kernel@vger.kernel.org, Marek Vasut,
Rob Herring, bcm-kernel-feedback-list@broadcom.com, Brian Norris,
David Woodhouse
Schrempf Frieder <frieder.schrempf@kontron.de> wrote on Tue, 21 May
2019 09:31:04 +0000:
> Hi Kamal,
>
> On 20.05.19 21:05, Kamal Dasu wrote:
> > nand-ecc-strength and nand-ecc-step-size can be made optional as
> > brcmnand driver can support using raw NAND layer detected values.
> >
> > Signed-off-by: Kamal Dasu <kdasu.kdev@gmail.com>
> > ---
> > Documentation/devicetree/bindings/mtd/brcm,brcmnand.txt | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/mtd/brcm,brcmnand.txt b/Documentation/devicetree/bindings/mtd/brcm,brcmnand.txt
> > index bcda1df..29feaba 100644
> > --- a/Documentation/devicetree/bindings/mtd/brcm,brcmnand.txt
> > +++ b/Documentation/devicetree/bindings/mtd/brcm,brcmnand.txt
> > @@ -101,10 +101,10 @@ Required properties:
> > number (e.g., 0, 1, 2, etc.)
> > - #address-cells : see partition.txt
> > - #size-cells : see partition.txt
> > -- nand-ecc-strength : see nand.txt
> > -- nand-ecc-step-size : must be 512 or 1024. See nand.txt
> >
> > Optional properties:
> > +- nand-ecc-strength : see nand.txt
> > +- nand-ecc-step-size : must be 512 or 1024. See nand.txt
> > - nand-on-flash-bbt : boolean, to enable the on-flash BBT for this
> > chip-select. See nand.txt
> > - brcm,nand-oob-sector-size : integer, to denote the spare area sector size
>
> I think you also need to change all references to nand.txt. This file
> was recently moved to nand-controller.yaml.
>
Oops, completely forgot about that *again*. Thanks for pointing it
Frieder!
Miquèl
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-05-21 9:32 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-05-20 19:05 [PATCH v2 1/2] dt-bindings: mtd: brcmnand: Make nand-ecc-strength and nand-ecc-step-size optional Kamal Dasu
2019-05-21 8:53 ` Miquel Raynal
2019-05-21 9:31 ` Schrempf Frieder
2019-05-21 9:32 ` Miquel Raynal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).