From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: [PATCH] arm64: dts: allwinner: a64: Add lradc node Date: Tue, 21 May 2019 15:09:55 +0200 Message-ID: <20190521130955.3omqwpx3i7njsb3t@flea> References: <20190518170929.24789-1-luca@z3ntu.xyz> <20190520110742.ykgxwaabzzwovgpl@flea> <9B2B83DF-2C91-4DDA-B707-664A792A8BCF@z3ntu.xyz> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="o4dueejzfmmapbjw" Return-path: Content-Disposition: inline In-Reply-To: <9B2B83DF-2C91-4DDA-B707-664A792A8BCF@z3ntu.xyz> Sender: linux-kernel-owner@vger.kernel.org To: luca@z3ntu.xyz Cc: Chen-Yu Tsai , Rob Herring , Mark Rutland , "moderated list:ARM/Allwinner sunXi SoC support" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list List-Id: devicetree@vger.kernel.org --o4dueejzfmmapbjw Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, May 21, 2019 at 08:43:45AM +0200, luca@z3ntu.xyz wrote: > On May 20, 2019 1:07:42 PM GMT+02:00, Maxime Ripard wrote: > >On Sat, May 18, 2019 at 07:09:30PM +0200, Luca Weiss wrote: > >> Add a node describing the KEYADC on the A64. > >> > >> Signed-off-by: Luca Weiss > >> --- > >> arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 7 +++++++ > >> 1 file changed, 7 insertions(+) > >> > >> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > >b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > >> index 7734f70e1057..dc1bf8c1afb5 100644 > >> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > >> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > >> @@ -704,6 +704,13 @@ > >> status = "disabled"; > >> }; > >> > >> + lradc: lradc@1c21800 { > >> + compatible = "allwinner,sun4i-a10-lradc-keys"; > >> + reg = <0x01c21800 0x100>; > >> + interrupts = ; > >> + status = "disabled"; > >> + }; > >> + > > > >The controller is pretty different on the A64 compared to the A10. The > >A10 has two channels for example, while the A64 has only one. > > > >It looks like the one in the A83t though, so you can use that > >compatible instead. > > Looking at the patch for the A83t, the only difference is that it > uses a 3/4 instead of a 2/3 voltage divider, nothing is changed with > the channels. I guess you can reuse the A83t compatible here then, and a more specific a64 compatible in case we ever need to fix this. > But I'm also not sure which one (or a different one) > is used from looking at the "A64 User Manual". I'm sorry, what are you referring to with "one" in that sentence? Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --o4dueejzfmmapbjw Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXOP4owAKCRDj7w1vZxhR xZkvAQCd5wzD/xjw3laO9nxjD2QxKl1qIHQW5BZeiCHbM1DA5wD/VtDKwN19wKfS efcYJj1jUOQM495DpaIysQG3XvYg3AA= =08Dd -----END PGP SIGNATURE----- --o4dueejzfmmapbjw--