From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthias Kaehlcke Subject: Re: [PATCH 1/2] ARM: dts: rockchip: Add pin names for rk3288-veyron-minnie Date: Tue, 21 May 2019 14:34:25 -0700 Message-ID: <20190521213425.GJ40515@google.com> References: <20190521203215.234898-1-dianders@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Content-Disposition: inline In-Reply-To: <20190521203215.234898-1-dianders@chromium.org> Sender: linux-kernel-owner@vger.kernel.org To: Douglas Anderson Cc: Heiko Stuebner , briannorris@chromium.org, ryandcase@chromium.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Rob Herring , Mark Rutland , linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org On Tue, May 21, 2019 at 01:32:14PM -0700, Douglas Anderson wrote: > We can now use the "gpio-line-names" property to provide the names for > all the pins on a board. Let's use this to provide the names for all > the pins on rk3288-veyron-minnie. > > In general the names here come straight from the schematic. That > means even if the schematic name is weird / doesn't have consistent > naming conventions / has typos I still haven't made any changes. > > The exception here is for two pins: the recovery switch and the write > protect detection pin. These two pins need to have standardized names > since crossystem (a Chrome OS tool) uses these names to query the > pins. In downstream kernels crossystem used an out-of-tree driver to > do this but it has now been moved to the gpiod API and needs the > standardized names. > > It's expected that other rk3288-veyron boards will get similar patches > shortly. > > NOTE: I have sorted the "gpio" section to be next to the "pinctrl" > section since it seems to logically make the most sense there. > > Signed-off-by: Douglas Anderson Reviewed-by: Matthias Kaehlcke