From: Andrew Lunn <andrew@lunn.ch>
To: Richard Cochran <richardcochran@gmail.com>
Cc: netdev@vger.kernel.org, David Miller <davem@davemloft.net>,
devicetree@vger.kernel.org,
Florian Fainelli <f.fainelli@gmail.com>,
Jacob Keller <jacob.e.keller@intel.com>,
Mark Rutland <mark.rutland@arm.com>,
Miroslav Lichvar <mlichvar@redhat.com>,
Rob Herring <robh+dt@kernel.org>,
Willem de Bruijn <willemb@google.com>
Subject: Re: [PATCH V3 net-next 3/6] net: Add a layer for non-PHY MII time stamping drivers.
Date: Wed, 22 May 2019 03:08:52 +0200 [thread overview]
Message-ID: <20190522010852.GE6577@lunn.ch> (raw)
In-Reply-To: <20190521224723.6116-4-richardcochran@gmail.com>
> +struct mii_timestamper *register_mii_timestamper(struct device_node *node,
> + unsigned int port)
> +{
> + struct mii_timestamper *mii_ts = NULL;
> + struct mii_timestamping_desc *desc;
> + struct list_head *this;
> +
> + mutex_lock(&tstamping_devices_lock);
> + list_for_each(this, &mii_timestamping_devices) {
> + desc = list_entry(this, struct mii_timestamping_desc, list);
> + if (desc->device->of_node == node) {
> + mii_ts = desc->ctrl->probe_channel(desc->device, port);
> + if (mii_ts) {
> + mii_ts->device = desc->device;
> + get_device(desc->device);
> + * @probe_channel: Callback into the controller driver announcing the
> + * presence of the 'port' channel. The 'device' field
> + * had been passed to register_mii_tstamp_controller().
> + * The driver must return either a pointer to a valid
> + * MII timestamper instance or PTR_ERR.
Hi Richard
probe_channel returns an PTR_ERR. So if (mii_ts) should probably be
if (IS_ERR(mii_ts))
Andrew
next prev parent reply other threads:[~2019-05-22 1:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-21 22:47 [PATCH V3 net-next 3/6] net: Add a layer for non-PHY MII time stamping drivers Richard Cochran
2019-05-22 1:08 ` Andrew Lunn [this message]
2019-05-28 5:19 ` Richard Cochran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190522010852.GE6577@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=jacob.e.keller@intel.com \
--cc=mark.rutland@arm.com \
--cc=mlichvar@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=robh+dt@kernel.org \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).