From: Maxime Ripard <maxime.ripard@bootlin.com>
To: Alexandre Torgue <alexandre.torgue@st.com>
Cc: "Mark Rutland" <mark.rutland@arm.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Frank Rowand" <frowand.list@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
"Chen-Yu Tsai" <wens@csie.org>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
devicetree@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
"Maxime Chevallier" <maxime.chevallier@bootlin.com>,
"Antoine Ténart" <antoine.tenart@bootlin.com>
Subject: Re: [PATCH 6/8] dt-bindings: net: stmmac: Convert the binding to a schemas
Date: Fri, 24 May 2019 09:34:55 +0200 [thread overview]
Message-ID: <20190524073455.46auhvhwb5no6ebp@flea> (raw)
In-Reply-To: <9094f39f-0e26-55dd-9b47-9a55089400da@st.com>
[-- Attachment #1: Type: text/plain, Size: 1202 bytes --]
Hi Alexandre,
On Thu, May 23, 2019 at 05:05:51PM +0200, Alexandre Torgue wrote:
> Hi Maxime
>
> On 5/23/19 11:56 AM, Maxime Ripard wrote:
> > Switch the STMMAC / Synopsys DesignWare MAC controller binding to a YAML
> > schema to enable the DT validation.
> >
> > Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
> > ---
>
> First, thanks a lot for this patch. Just one question:
> We could add ranges for some properties in order to avoid "bad value" for a
> property. If I understand correctly you do it only for snps,dwxgmac,
> snps,dwxgmac-2.10 and st,spear600-gmac. Why not do it for all supported IPs
> ? (Maybe it is something that we could add later)
>
We definitely can do that. It wasn't really obvious to me what the
limits were by reading the previous documentation, but if you can
provide them we can definitely add them.
> > + snps,tso:
> > + $ref: /schemas/types.yaml#definitions/flag
> > + description:
> > + Enables the TSO feature otherwise it will be managed by
> > + MAC HW capability register. Only for GMAC4 and newer.
>
> TSO is also available for snps,dwmac-4.00 and snps,dwmac-4.10a
Ack, I'll change it.
Thanks!
Maxime
next prev parent reply other threads:[~2019-05-24 7:34 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-23 9:56 [PATCH 1/8] dt-bindings: net: Add YAML schemas for the generic Ethernet options Maxime Ripard
2019-05-23 9:56 ` [PATCH 2/8] dt-bindings: net: Add a YAML schemas for the generic PHY options Maxime Ripard
2019-05-23 14:37 ` Andrew Lunn
2019-05-23 20:01 ` Maxime Ripard
2019-05-23 14:44 ` Rob Herring
2019-05-24 11:06 ` Maxime Ripard
2019-05-23 18:16 ` Florian Fainelli
2019-05-24 8:10 ` Maxime Ripard
2019-05-23 9:56 ` [PATCH 3/8] dt-bindings: net: phy: The interrupt property is not mandatory Maxime Ripard
2019-05-23 9:56 ` [PATCH 4/8] dt-bindings: net: sun4i-emac: Convert the binding to a schemas Maxime Ripard
2019-05-23 9:56 ` [PATCH 5/8] dt-bindings: net: sun4i-mdio: " Maxime Ripard
2019-05-23 9:56 ` [PATCH 6/8] dt-bindings: net: stmmac: " Maxime Ripard
2019-05-23 10:11 ` Jose Abreu
2019-05-23 11:07 ` Maxime Ripard
2019-05-23 11:25 ` Jose Abreu
2019-05-23 12:45 ` Maxime Ripard
2019-05-23 15:05 ` Alexandre Torgue
2019-05-24 7:34 ` Maxime Ripard [this message]
2019-05-23 15:33 ` Rob Herring
2019-05-24 9:05 ` Maxime Ripard
2019-05-23 9:56 ` [PATCH 7/8] dt-bindings: net: sun7i-gmac: " Maxime Ripard
2019-05-23 15:55 ` Rob Herring
2019-05-23 9:56 ` [PATCH 8/8] dt-bindings: net: sun8i-emac: " Maxime Ripard
2019-05-23 13:10 ` [PATCH 1/8] dt-bindings: net: Add YAML schemas for the generic Ethernet options Rob Herring
2019-05-23 14:42 ` Andrew Lunn
2019-05-23 19:54 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190524073455.46auhvhwb5no6ebp@flea \
--to=maxime.ripard@bootlin.com \
--cc=alexandre.torgue@st.com \
--cc=antoine.tenart@bootlin.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mark.rutland@arm.com \
--cc=maxime.chevallier@bootlin.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox