From mboxrd@z Thu Jan 1 00:00:00 1970 From: Will Deacon Subject: Re: [RFT PATCH v5 3/5] cpu-topology: Move cpu topology code to common code. Date: Fri, 24 May 2019 10:38:41 +0100 Message-ID: <20190524093754.GA3432@fuggles.cambridge.arm.com> References: <20190524000653.13005-1-atish.patra@wdc.com> <20190524000653.13005-4-atish.patra@wdc.com> <20190524081333.GA15566@kroah.com> <20190524085720.GA13121@e107155-lin> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20190524085720.GA13121@e107155-lin> Sender: linux-kernel-owner@vger.kernel.org To: Sudeep Holla Cc: Greg Kroah-Hartman , Atish Patra , linux-kernel@vger.kernel.org, Jeffrey Hugo , Albert Ou , Andreas Schwab , Anup Patel , Catalin Marinas , devicetree@vger.kernel.org, Ingo Molnar , Jeremy Linton , linux-riscv@lists.infradead.org, Mark Rutland , Morten Rasmussen , Otto Sabart , Palmer Dabbelt , Paul Walmsley , "Peter Zijlstra (Intel)" , "Rafael J. Wysocki" , Rob Herring , Tho List-Id: devicetree@vger.kernel.org On Fri, May 24, 2019 at 09:57:40AM +0100, Sudeep Holla wrote: > On Fri, May 24, 2019 at 10:13:33AM +0200, Greg Kroah-Hartman wrote: > > On Thu, May 23, 2019 at 05:06:50PM -0700, Atish Patra wrote: > > > Both RISC-V & ARM64 are using cpu-map device tree to describe > > > their cpu topology. It's better to move the relevant code to > > > a common place instead of duplicate code. > > > > > > Signed-off-by: Atish Patra > > > Tested-by: Jeffrey Hugo > > > --- > > > arch/arm64/include/asm/topology.h | 23 --- > > > arch/arm64/kernel/topology.c | 303 +----------------------------- > > > drivers/base/arch_topology.c | 296 +++++++++++++++++++++++++++++ > > > include/linux/arch_topology.h | 28 +++ > > > include/linux/topology.h | 1 + > > > 5 files changed, 329 insertions(+), 322 deletions(-) > > > > What, now _I_ have to maintain drivers/base/arch_topology.c? That's > > nice for everyone else, but not me :( > > > > Ugh. > > > > Anyway, what are you wanting to happen to this series? I think we need > > some ARM people to sign off on it before I can take the whole thing, > > right? > > > > Greg, I am ready to take ownership. Juri the original author of this file > agreed and I have been reviewing this file since Juri first wrote it. > I am happy to submit a patch assuming maintainership for this file, was > just waiting to hear from you when I asked explicitly you and Juri in > last version of the patch when Will wanted someone from ARM to be reviewer > of this file at-least. I am happy to take over as reviewer or maintainer > which ever you prefer. Yes, please just include this update to MAINTAINERS as part of the series. I'll ack it. Will