From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: [PATCH 6/6] arm64: dts: allwinner: a64: enable ANX6345 bridge on Teres-I Date: Fri, 24 May 2019 15:06:23 +0200 Message-ID: <20190524130623.dpkg5z5rdyc2bno4@flea> References: <20190523065013.2719D68B05@newverein.lst.de> <20190523065404.BB60F68B20@newverein.lst.de> <20190524121359.GE15685@lst.de> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="fsxi6i2r62yvgbvk" Return-path: Content-Disposition: inline In-Reply-To: <20190524121359.GE15685@lst.de> Sender: linux-kernel-owner@vger.kernel.org To: Torsten Duwe Cc: Vasily Khoruzhick , Chen-Yu Tsai , Rob Herring , Mark Rutland , Thierry Reding , David Airlie , Daniel Vetter , Andrzej Hajda , Laurent Pinchart , Icenowy Zheng , Sean Paul , Harald Geyer , Greg Kroah-Hartman , Thomas Gleixner , dri-devel , devicetree , arm-linux , linux-kernel List-Id: devicetree@vger.kernel.org --fsxi6i2r62yvgbvk Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, May 24, 2019 at 02:13:59PM +0200, Torsten Duwe wrote: > On Thu, May 23, 2019 at 07:48:03AM -0700, Vasily Khoruzhick wrote: > > On Wed, May 22, 2019 at 11:54 PM Torsten Duwe wrote: > > > > > > > > > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-teres-i.dts > > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-teres-i.dts > > > @@ -65,6 +65,21 @@ > > > }; > > > }; > > > > > > + panel: panel { > > > + compatible ="innolux,n116bge", "simple-panel"; > > > > IIRC Rob wanted it to be edp-connector, not simple-panel. Also you > > need to introduce edp-connector binding. > > This line is identically found in > arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi and > arch/arm64/boot/dts/nvidia/tegra132-norrin.dts That's not really an argument though. These are using rather old bindings, and realising that they are flawed and fixing these flaws is a natural process. Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --fsxi6i2r62yvgbvk Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXOfsTwAKCRDj7w1vZxhR xRybAP9iKNkCqyhXQ6xIsRZgZ0sNXT+q0aHuuuRwgIKZaEJwkwEAqakTF1EIu2Pr 7DcRHe8aaX/5zfuRYUOdKKZ/wNaOdQ0= =Mlxd -----END PGP SIGNATURE----- --fsxi6i2r62yvgbvk--