From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH v4 1/3] amr64: map FDT as RW for early_init_dt_scan() Date: Fri, 24 May 2019 16:58:38 -0500 Message-ID: <20190524215838.GA16271@bogus> References: <20190519160446.320-1-hsinyi@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20190519160446.320-1-hsinyi@chromium.org> Sender: linux-kernel-owner@vger.kernel.org To: Hsin-Yi Wang Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Frank Rowand , Catalin Marinas , Will Deacon , Andrew Morton , Mike Rapoport , Ard Biesheuvel , Miles Chen , James Morse , Andrew Murray , Mark Rutland , Jun Yao , Yu Zhao , Robin Murphy , Laura Abbott , Stephen Boyd , Kees Cook List-Id: devicetree@vger.kernel.org On Mon, May 20, 2019 at 12:04:44AM +0800, Hsin-Yi Wang wrote: > Currently in arm64, FDT is mapped to RO before it's passed to > early_init_dt_scan(). However, there might be some code that needs > to modify FDT during init. Map FDT to RW until unflatten DT. typo in the subject. Otherwise, this one seems fine to me. > > Signed-off-by: Hsin-Yi Wang > --- > change log v2->v4: > * v3 abandoned > * add an arg pgprot_t to fixmap_remap_fdt() > --- > arch/arm64/include/asm/mmu.h | 2 +- > arch/arm64/kernel/setup.c | 5 ++++- > arch/arm64/mm/mmu.c | 4 ++-- > 3 files changed, 7 insertions(+), 4 deletions(-)